Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customer bill writer also to consume topics #726

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

matiit
Copy link
Contributor

@matiit matiit commented Dec 12, 2024

No description provided.

@matiit matiit requested a review from a team as a code owner December 12, 2024 12:15
Copy link

linear bot commented Dec 12, 2024

@uw-infra
Copy link

uw-infra commented Dec 12, 2024

Terraform run output for

Cluster: prod-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: prod-aws/kafka-shared-msk/account-identity
Commit ID: be6329f4d0a0bc48bb0d648ce9adc9f5f06df4b9
✅ Run Status: Ok, Run Summary: Plan: 2 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.group_acl["account-identity.account-api-v2-customer-bill-writer"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_customer_bill_writer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account-api-v2-customer-bill-writer"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.topic_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_customer_bill_writer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan prod-aws/kafka-shared-msk/account-identity as comment.

@uw-infra
Copy link

uw-infra commented Dec 12, 2024

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: be6329f4d0a0bc48bb0d648ce9adc9f5f06df4b9
✅ Run Status: Ok, Run Summary: Plan: 2 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.group_acl["account-identity.account-api-v2-customer-bill-writer"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_customer_bill_writer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account-api-v2-customer-bill-writer"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.topic_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_customer_bill_writer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

1 similar comment
@uw-infra
Copy link

uw-infra commented Dec 12, 2024

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: be6329f4d0a0bc48bb0d648ce9adc9f5f06df4b9
✅ Run Status: Ok, Run Summary: Plan: 2 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.group_acl["account-identity.account-api-v2-customer-bill-writer"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_customer_bill_writer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account-api-v2-customer-bill-writer"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.topic_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_customer_bill_writer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

@matiit matiit merged commit d6a720d into main Dec 12, 2024
2 checks passed
@matiit matiit deleted the acc-954-business-acc-writing-to-bill branch December 12, 2024 12:34
@uw-infra
Copy link

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: d6a720d6bcaabebf7836d1cd6a0fd2a8b55dcdc6
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 3 added, 0 changed, 0 destroyed
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # kafka_topic.account_identity_account_bill_writes_public will be created
  + resource "kafka_topic" "account_identity_account_bill_writes_public" {
      + config             = {
          + "cleanup.policy"        = "compact"
          + "compression.type"      = "zstd"
          + "max.compaction.lag.ms" = "604800000"
        }
      + id                 = (known after apply)
      + name               = "account-identity.account.bill.writes.public"
      + partitions         = 15
      + replication_factor = 3
    }

  # module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.group_acl["account-identity.account-api-v2-customer-bill-writer"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_customer_bill_writer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account-api-v2-customer-bill-writer"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.topic_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_customer_bill_writer"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 3 to add, 0 to change, 0 to destroy.
kafka_topic.account_identity_account_bill_writes_public: Creating...
module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.group_acl["account-identity.account-api-v2-customer-bill-writer"]: Creating...
module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.topic_acl["account-identity.account.events.v2"]: Creating...
module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.topic_acl["account-identity.account.events.v2"]: Creation complete after 1s [id=User:CN=account-platform/account_api_v2_customer_bill_writer|*|Read|Allow|Topic|account-identity.account.events.v2|Literal]
module.account_identity_account_api_v2_customer_bill_writer.kafka_acl.group_acl["account-identity.account-api-v2-customer-bill-writer"]: Creation complete after 1s [id=User:CN=account-platform/account_api_v2_customer_bill_writer|*|Read|Allow|Group|account-identity.account-api-v2-customer-bill-writer|Literal]
kafka_topic.account_identity_account_bill_writes_public: Creation complete after 1s [id=account-identity.account.bill.writes.public]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_cert` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 3 added, 0 changed, 0 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants