Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account-identity: Add business validation projector consumer #725

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Jarota
Copy link
Contributor

@Jarota Jarota commented Dec 12, 2024

@Jarota Jarota marked this pull request as ready for review December 12, 2024 12:02
@Jarota Jarota requested a review from a team as a code owner December 12, 2024 12:02
@uw-infra
Copy link

uw-infra commented Dec 12, 2024

Terraform run output for

Cluster: prod-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: prod-aws/kafka-shared-msk/account-identity
Commit ID: ffce74c7d5e1b2dea9d7e19155795023318619a6
✅ Run Status: Ok, Run Summary: Plan: 3 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # kafka_topic.account_identity_account_bill_writes_public will be created
  + resource "kafka_topic" "account_identity_account_bill_writes_public" {
      + config             = {
          + "cleanup.policy"        = "compact"
          + "compression.type"      = "zstd"
          + "max.compaction.lag.ms" = "604800000"
        }
      + id                 = (known after apply)
      + name               = "account-identity.account.bill.writes.public"
      + partitions         = 15
      + replication_factor = 3
    }

  # kafka_topic.account_identity_accunt_bill_writes_public will be destroyed
  # (because kafka_topic.account_identity_accunt_bill_writes_public is not in configuration)
  - resource "kafka_topic" "account_identity_accunt_bill_writes_public" {
      - config             = {
          - "cleanup.policy"        = "compact"
          - "compression.type"      = "zstd"
          - "max.compaction.lag.ms" = "604800000"
        } -> null
      - id                 = "account-identity.account.bill.writes.public" -> null
      - name               = "account-identity.account.bill.writes.public" -> null
      - partitions         = 15 -> null
      - replication_factor = 3 -> null
    }

  # module.account_identity_account_api_business_validation_projector.kafka_acl.group_acl["account-identity.account-api-business-validation-projector"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_business_validation_projector"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account-api-business-validation-projector"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.account_identity_account_api_business_validation_projector.kafka_acl.topic_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_business_validation_projector"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 3 to add, 0 to change, 1 to destroy.

To manually trigger plan again please post @terraform-applier plan prod-aws/kafka-shared-msk/account-identity as comment.

@uw-infra
Copy link

uw-infra commented Dec 12, 2024

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: ffce74c7d5e1b2dea9d7e19155795023318619a6
✅ Run Status: Ok, Run Summary: Plan: 3 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # kafka_topic.account_identity_account_bill_writes_public will be created
  + resource "kafka_topic" "account_identity_account_bill_writes_public" {
      + config             = {
          + "cleanup.policy"        = "compact"
          + "compression.type"      = "zstd"
          + "max.compaction.lag.ms" = "604800000"
        }
      + id                 = (known after apply)
      + name               = "account-identity.account.bill.writes.public"
      + partitions         = 15
      + replication_factor = 3
    }

  # kafka_topic.account_identity_accunt_bill_writes_public will be destroyed
  # (because kafka_topic.account_identity_accunt_bill_writes_public is not in configuration)
  - resource "kafka_topic" "account_identity_accunt_bill_writes_public" {
      - config             = {
          - "cleanup.policy"        = "compact"
          - "compression.type"      = "zstd"
          - "max.compaction.lag.ms" = "604800000"
        } -> null
      - id                 = "account-identity.account.bill.writes.public" -> null
      - name               = "account-identity.account.bill.writes.public" -> null
      - partitions         = 15 -> null
      - replication_factor = 3 -> null
    }

  # module.account_identity_account_api_business_validation_projector.kafka_acl.group_acl["account-identity.account-api-business-validation-projector"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_business_validation_projector"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account-api-business-validation-projector"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.account_identity_account_api_business_validation_projector.kafka_acl.topic_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_business_validation_projector"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 3 to add, 0 to change, 1 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

@@ -120,7 +120,7 @@ resource "kafka_topic" "account_identity_to_anonymize_events" {
replication_factor = 3
}

resource "kafka_topic" "account_identity_accunt_bill_writes_public" {
resource "kafka_topic" "account_identity_account_bill_writes_public" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@Jarota Jarota merged commit 1d1652f into main Dec 12, 2024
2 checks passed
@Jarota Jarota deleted the acc-api-business-validator branch December 12, 2024 12:15
@uw-infra
Copy link

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: 1d1652f30eb68ddb57457c32847ab1ad267b1d48
⛔ Run Status: Errored, Run Summary: unable to apply module
{
  "terraform_version": "1.8.0",
  "platform": "linux_amd64",
  "provider_selections": {},
  "terraform_outdated": true
}

Initializing the backend...

Successfully configured the backend "s3"! Terraform will automatically
use this backend unless the backend configuration changes.
Initializing modules...
- account_identity_account_api in ../../../modules/tls-app
- account_identity_account_api_atomic_projector in ../../../modules/tls-app
- account_identity_account_api_business_validation_projector in ../../../modules/tls-app
- account_identity_account_api_change_notifier in ../../../modules/tls-app
- account_identity_account_api_v2 in ../../../modules/tls-app
- account_identity_account_api_v2_customer_bill_writer in ../../../modules/tls-app
- account_identity_account_api_v2_dispatcher in ../../../modules/tls-app
- account_identity_account_atomic_to_internal in ../../../modules/tls-app
- account_identity_account_atomic_v1_indexer in ../../../modules/tls-app
- account_identity_account_events_anonymized_indexer in ../../../modules/tls-app
- account_identity_account_events_anonymized_v1_indexer in ../../../modules/tls-app
- account_identity_account_events_compaction_relay in ../../../modules/tls-app
- account_identity_account_events_created_in_bill_indexer in ../../../modules/tls-app
- account_identity_account_events_v2_indexer in ../../../modules/tls-app
- account_identity_account_exceptions_events_indexer in ../../../modules/tls-app
- account_identity_account_exceptions_v1_indexer in ../../../modules/tls-app
- account_identity_account_number_anonymized_projector in ../../../modules/tls-app
- account_identity_account_number_seed_projector in ../../../modules/tls-app
- account_identity_account_to_land_registry_events_relay in ../../../modules/tls-app
- account_identity_account_v2_to_legacy in ../../../modules/tls-app
- account_identity_anonymized_to_unified in ../../../modules/tls-app
- account_identity_bill_writer in ../../../modules/tls-app
- account_identity_braze_events_indexer in ../../../modules/tls-app
- account_identity_correspondence_address_debt_checker in ../../../modules/tls-app
- account_identity_correspondence_address_debt_finance_relay in ../../../modules/tls-app
- account_identity_correspondence_address_matching_checker in ../../../modules/tls-app
- account_identity_correspondence_address_relay in ../../../modules/tls-app
- account_identity_create_account_projector in ../../../modules/tls-app
- account_identity_created_to_unified in ../../../modules/tls-app
- account_identity_crm_okta_projector in ../../../modules/tls-app
- account_identity_debt_corresp_events_relay in ../../../modules/tls-app
- account_identity_debt_events_compaction_relay in ../../../modules/tls-app
- account_identity_debt_events_relay in ../../../modules/tls-app
- account_identity_di_addr_lookup in ../../../modules/tls-app
- account_identity_di_business_events in ../../../modules/tls-app
- account_identity_di_exceptions in ../../../modules/tls-app
- account_identity_di_legacy_account in ../../../modules/tls-app
- account_identity_eqdb_loader in ../../../modules/tls-app
- account_identity_events_anonymizer in ../../../modules/tls-app
- account_identity_exceptions_processor in ../../../modules/tls-app
- account_identity_exceptions_service_projector in ../../../modules/tls-app
- account_identity_from_prod_relay in ../../../modules/tls-app
- account_identity_graphql_api in ../../../modules/tls-app
- account_identity_graphql_projector in ../../../modules/tls-app
- account_identity_holders_mapper in ../../../modules/tls-app
- account_identity_home_move_projector in ../../../modules/tls-app
- account_identity_internal_legacy_account_indexer in ../../../modules/tls-app
- account_identity_internal_supply_address_debt_relay in ../../../modules/tls-app
- account_identity_land_registry_checker in ../../../modules/tls-app
- account_identity_land_registry_failures_projector in ../../../modules/tls-app
- account_identity_land_registry_failures_retrier in ../../../modules/tls-app
- account_identity_land_registry_indexer in ../../../modules/tls-app
- account_identity_legacy_account_braze_relay in ../../../modules/tls-app
- account_identity_legacy_account_created_in_bill_relay in ../../../modules/tls-app
- account_identity_legacy_account_differ in ../../../modules/tls-app
- account_identity_legacy_account_events_compacted_indexer in ../../../modules/tls-app
- account_identity_legacy_account_events_indexer in ../../../modules/tls-app
- account_identity_legacy_account_holder_compaction in ../../../modules/tls-app
- account_identity_legacy_account_mux in ../../../modules/tls-app
- account_identity_legacy_account_projector in ../../../modules/tls-app
- account_identity_legacy_account_translator in ../../../modules/tls-app
- account_identity_legacy_acount_change_event_uswitch_reporter in ../../../modules/tls-app
- account_identity_legacy_correspondence_address_relay in ../../../modules/tls-app
- account_identity_legacy_dispatcher in ../../../modules/tls-app
- account_identity_legacy_supply_address_relay in ../../../modules/tls-app
- account_identity_legacy_to_anonymize_relay in ../../../modules/tls-app
- account_identity_legacy_to_unified in ../../../modules/tls-app
- account_identity_okta_staff_events_indexer in ../../../modules/tls-app
- account_identity_private_to_public_relay in ../../../modules/tls-app
- account_identity_proximo in ../../../modules/tls-app
- account_identity_public_account_events_indexer in ../../../modules/tls-app
- account_identity_staff_api_projector in ../../../modules/tls-app
- account_identity_staff_okta_producer in ../../../modules/tls-app
- account_identity_supply_address_debt_checker in ../../../modules/tls-app
- account_identity_supply_address_debt_finance_relay in ../../../modules/tls-app
- account_identity_supply_address_debt_relay in ../../../modules/tls-app
- account_identity_supply_address_matching_checker in ../../../modules/tls-app
- account_identity_supply_address_relay in ../../../modules/tls-app
- account_identity_to_anonymize in ../../../modules/tls-app
- account_identity_unified_events_indexer in ../../../modules/tls-app
- account_identity_update_account_projector in ../../../modules/tls-app
- account_identity_update_holders in ../../../modules/tls-app
- account_identity_verification_api in ../../../modules/tls-app
- account_identity_verification_indexer in ../../../modules/tls-app
- account_identity_verification_link_sender in ../../../modules/tls-app
- cbc_account_events_relay in ../../../modules/tls-app
- cbc_fraud_detection_consumer in ../../../modules/tls-app
- contact_channels_account_events_consumer in ../../../modules/tls-app
- customer_support_crm in ../../../modules/tls-app
- customer_support_crm_idv in ../../../modules/tls-app
- iam_dpd_mapper in ../../../modules/tls-app
- quoting_platform_account_projector in ../../../modules/tls-app

Initializing provider plugins...
- Finding mongey/kafka versions matching ">= 0.7.0"...
- Using mongey/kafka v0.8.3 from the shared cache directory

Terraform has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.


Warning: Incomplete lock file information for providers

Due to your customized provider installation methods, Terraform was forced to
calculate lock file checksums locally for the following providers:
  - mongey/kafka

The current .terraform.lock.hcl file only includes checksums for linux_amd64,
so Terraform running on another platform will fail to install these
providers.

To calculate additional checksums for another platform, run:
  terraform providers lock -platform=linux_amd64
(where linux_amd64 is the platform to generate)

Terraform has been successfully initialized!

unable to apply module

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # kafka_topic.account_identity_account_bill_writes_public will be created
  + resource "kafka_topic" "account_identity_account_bill_writes_public" {
      + config             = {
          + "cleanup.policy"        = "compact"
          + "compression.type"      = "zstd"
          + "max.compaction.lag.ms" = "604800000"
        }
      + id                 = (known after apply)
      + name               = "account-identity.account.bill.writes.public"
      + partitions         = 15
      + replication_factor = 3
    }

  # kafka_topic.account_identity_accunt_bill_writes_public will be destroyed
  # (because kafka_topic.account_identity_accunt_bill_writes_public is not in configuration)
  - resource "kafka_topic" "account_identity_accunt_bill_writes_public" {
      - config             = {
          - "cleanup.policy"        = "compact"
          - "compression.type"      = "zstd"
          - "max.compaction.lag.ms" = "604800000"
        } -> null
      - id                 = "account-identity.account.bill.writes.public" -> null
      - name               = "account-identity.account.bill.writes.public" -> null
      - partitions         = 15 -> null
      - replication_factor = 3 -> null
    }

  # module.account_identity_account_api_business_validation_projector.kafka_acl.group_acl["account-identity.account-api-business-validation-projector"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_business_validation_projector"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account-api-business-validation-projector"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.account_identity_account_api_business_validation_projector.kafka_acl.topic_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_business_validation_projector"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 3 to add, 0 to change, 1 to destroy.
kafka_topic.account_identity_accunt_bill_writes_public: Destroying... [id=account-identity.account.bill.writes.public]
module.account_identity_account_api_business_validation_projector.kafka_acl.group_acl["account-identity.account-api-business-validation-projector"]: Creating...
kafka_topic.account_identity_account_bill_writes_public: Creating...
module.account_identity_account_api_business_validation_projector.kafka_acl.topic_acl["account-identity.account.events.v2"]: Creating...
module.account_identity_account_api_business_validation_projector.kafka_acl.topic_acl["account-identity.account.events.v2"]: Creation complete after 1s [id=User:CN=account-platform/account_api_business_validation_projector|*|Read|Allow|Topic|account-identity.account.events.v2|Literal]
module.account_identity_account_api_business_validation_projector.kafka_acl.group_acl["account-identity.account-api-business-validation-projector"]: Creation complete after 1s [id=User:CN=account-platform/account_api_business_validation_projector|*|Read|Allow|Group|account-identity.account-api-business-validation-projector|Literal]
kafka_topic.account_identity_accunt_bill_writes_public: Destruction complete after 4s

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_key` instead.

(and one more similar warning elsewhere)

Error: kafka server: Topic with this name already exists

  with kafka_topic.account_identity_account_bill_writes_public,
  on account.tf line 123, in resource "kafka_topic" "account_identity_account_bill_writes_public":
 123: resource "kafka_topic" "account_identity_account_bill_writes_public" {

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants