Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add topic for move out notification" #724

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

abramin
Copy link
Contributor

@abramin abramin commented Dec 11, 2024

Reverts #722

@abramin abramin requested a review from a team as a code owner December 11, 2024 15:15
@uw-infra
Copy link

uw-infra commented Dec 11, 2024

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: 252e4b08e6446de18b3d38430cbdd2d605fcfc1d
✅ Run Status: Ok, Run Summary: Plan: 0 to add, 0 to change, 3 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # kafka_topic.account_identity_analytics_v1 will be destroyed
  # (because kafka_topic.account_identity_analytics_v1 is not in configuration)
  - resource "kafka_topic" "account_identity_analytics_v1" {
      - config             = {
          - "cleanup.policy"        = "delete"
          - "compression.type"      = "zstd"
          - "local.retention.ms"    = "86400000"
          - "remote.storage.enable" = "true"
          - "retention.ms"          = "604800000"
        } -> null
      - id                 = "account-identity.analytics.v1" -> null
      - name               = "account-identity.analytics.v1" -> null
      - partitions         = 15 -> null
      - replication_factor = 3 -> null
    }

  # module.account_identity_di_analytics.kafka_acl.group_acl["account-identity.di-kafka-source-move-out-notification"] will be destroyed
  # (because kafka_acl.group_acl is not in configuration)
  - resource "kafka_acl" "group_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/di_analytics" -> null
      - id                           = "User:CN=account-platform/di_analytics|*|Read|Allow|Group|account-identity.di-kafka-source-move-out-notification|Literal" -> null
      - resource_name                = "account-identity.di-kafka-source-move-out-notification" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Group" -> null
    }

  # module.account_identity_di_analytics.kafka_acl.topic_acl["account-identity.analytics.v1"] will be destroyed
  # (because kafka_acl.topic_acl is not in configuration)
  - resource "kafka_acl" "topic_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/di_analytics" -> null
      - id                           = "User:CN=account-platform/di_analytics|*|Read|Allow|Topic|account-identity.analytics.v1|Literal" -> null
      - resource_name                = "account-identity.analytics.v1" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Topic" -> null
    }

Plan: 0 to add, 0 to change, 3 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

@abramin abramin enabled auto-merge (squash) December 11, 2024 15:16
@uw-infra
Copy link

uw-infra commented Dec 11, 2024

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: 8da1c1ecaa29e60e382df078201cc8e7eeb998e7
✅ Run Status: Ok, Run Summary: Plan: 0 to add, 0 to change, 3 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # kafka_topic.account_identity_analytics_v1 will be destroyed
  # (because kafka_topic.account_identity_analytics_v1 is not in configuration)
  - resource "kafka_topic" "account_identity_analytics_v1" {
      - config             = {
          - "cleanup.policy"        = "delete"
          - "compression.type"      = "zstd"
          - "local.retention.ms"    = "86400000"
          - "remote.storage.enable" = "true"
          - "retention.ms"          = "604800000"
        } -> null
      - id                 = "account-identity.analytics.v1" -> null
      - name               = "account-identity.analytics.v1" -> null
      - partitions         = 15 -> null
      - replication_factor = 3 -> null
    }

  # module.account_identity_di_analytics.kafka_acl.group_acl["account-identity.di-kafka-source-move-out-notification"] will be destroyed
  # (because kafka_acl.group_acl is not in configuration)
  - resource "kafka_acl" "group_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/di_analytics" -> null
      - id                           = "User:CN=account-platform/di_analytics|*|Read|Allow|Group|account-identity.di-kafka-source-move-out-notification|Literal" -> null
      - resource_name                = "account-identity.di-kafka-source-move-out-notification" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Group" -> null
    }

  # module.account_identity_di_analytics.kafka_acl.topic_acl["account-identity.analytics.v1"] will be destroyed
  # (because kafka_acl.topic_acl is not in configuration)
  - resource "kafka_acl" "topic_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/di_analytics" -> null
      - id                           = "User:CN=account-platform/di_analytics|*|Read|Allow|Topic|account-identity.analytics.v1|Literal" -> null
      - resource_name                = "account-identity.analytics.v1" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Topic" -> null
    }

Plan: 0 to add, 0 to change, 3 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

@abramin abramin merged commit afb82bc into main Dec 11, 2024
2 checks passed
@abramin abramin deleted the revert-722-move-out branch December 11, 2024 15:26
@uw-infra
Copy link

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: afb82bcb743b0f7d8c8d142dc220abd9c89fb487
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 0 added, 0 changed, 3 destroyed
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # kafka_topic.account_identity_analytics_v1 will be destroyed
  # (because kafka_topic.account_identity_analytics_v1 is not in configuration)
  - resource "kafka_topic" "account_identity_analytics_v1" {
      - config             = {
          - "cleanup.policy"        = "delete"
          - "compression.type"      = "zstd"
          - "local.retention.ms"    = "86400000"
          - "remote.storage.enable" = "true"
          - "retention.ms"          = "604800000"
        } -> null
      - id                 = "account-identity.analytics.v1" -> null
      - name               = "account-identity.analytics.v1" -> null
      - partitions         = 15 -> null
      - replication_factor = 3 -> null
    }

  # module.account_identity_di_analytics.kafka_acl.group_acl["account-identity.di-kafka-source-move-out-notification"] will be destroyed
  # (because kafka_acl.group_acl is not in configuration)
  - resource "kafka_acl" "group_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/di_analytics" -> null
      - id                           = "User:CN=account-platform/di_analytics|*|Read|Allow|Group|account-identity.di-kafka-source-move-out-notification|Literal" -> null
      - resource_name                = "account-identity.di-kafka-source-move-out-notification" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Group" -> null
    }

  # module.account_identity_di_analytics.kafka_acl.topic_acl["account-identity.analytics.v1"] will be destroyed
  # (because kafka_acl.topic_acl is not in configuration)
  - resource "kafka_acl" "topic_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/di_analytics" -> null
      - id                           = "User:CN=account-platform/di_analytics|*|Read|Allow|Topic|account-identity.analytics.v1|Literal" -> null
      - resource_name                = "account-identity.analytics.v1" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Topic" -> null
    }

Plan: 0 to add, 0 to change, 3 to destroy.
module.account_identity_di_analytics.kafka_acl.group_acl["account-identity.di-kafka-source-move-out-notification"]: Destroying... [id=User:CN=account-platform/di_analytics|*|Read|Allow|Group|account-identity.di-kafka-source-move-out-notification|Literal]
module.account_identity_di_analytics.kafka_acl.topic_acl["account-identity.analytics.v1"]: Destroying... [id=User:CN=account-platform/di_analytics|*|Read|Allow|Topic|account-identity.analytics.v1|Literal]
module.account_identity_di_analytics.kafka_acl.group_acl["account-identity.di-kafka-source-move-out-notification"]: Destruction complete after 1s
module.account_identity_di_analytics.kafka_acl.topic_acl["account-identity.analytics.v1"]: Destruction complete after 1s
kafka_topic.account_identity_analytics_v1: Destroying... [id=account-identity.analytics.v1]
kafka_topic.account_identity_analytics_v1: Destruction complete after 3s

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_cert` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 0 added, 0 changed, 3 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants