Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account api now produces to more topics #717

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Account api now produces to more topics #717

merged 3 commits into from
Dec 2, 2024

Conversation

matiit
Copy link
Contributor

@matiit matiit commented Nov 28, 2024

No description provided.

@matiit matiit requested a review from a team as a code owner November 28, 2024 15:41
@linear Linear
Copy link

linear bot commented Nov 28, 2024

ACC-954 Allow Creation of Business Accounts

@uw-infra
Copy link

uw-infra commented Nov 28, 2024 •
edited
Loading

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: b50205e5b43b0cda556ae505a8e42e2fcd5b6e64
✅ Run Status: Ok, Run Summary: Plan: 2 to add, 0 to change, 1 to destroy. 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.atomic.v1"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.atomic.v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.account_identity_account_api.kafka_acl.producer_acl["account-identity.internal.legacy.account.events"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api"
      + id                           = (known after apply)
      + resource_name                = "account-identity.internal.legacy.account.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.account_identity_account_api_account_atomic_producer.kafka_acl.producer_acl["account-identity.account.atomic.v1"] will be destroyed
  # (because kafka_acl.producer_acl is not in configuration)
  - resource "kafka_acl" "producer_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Write" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/account_api_account_atomic_producer" -> null
      - id                           = "User:CN=account-platform/account_api_account_atomic_producer|*|Write|Allow|Topic|account-identity.account.atomic.v1|Literal" -> null
      - resource_name                = "account-identity.account.atomic.v1" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Topic" -> null
    }

Plan: 2 to add, 0 to change, 1 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

@uw-infra
Copy link

uw-infra commented Dec 2, 2024 •
edited
Loading

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: 7331b355f55962997d76d37016d18ab1c7b625b8
✅ Run Status: Ok, Run Summary: Plan: 3 to add, 0 to change, 1 to destroy. 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # kafka_topic.account_identity_business_account_creation_events will be created
  + resource "kafka_topic" "account_identity_business_account_creation_events" {
      + config             = {
          + "cleanup.policy"        = "compact"
          + "compression.type"      = "zstd"
          + "max.compaction.lag.ms" = "604800000"
        }
      + id                 = (known after apply)
      + name               = "account-identity.account.business.creation.public"
      + partitions         = 15
      + replication_factor = 3
    }

  # module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.atomic.v1"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.atomic.v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.business.creation.public"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.business.creation.public"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.account_identity_account_api_account_atomic_producer.kafka_acl.producer_acl["account-identity.account.atomic.v1"] will be destroyed
  # (because kafka_acl.producer_acl is not in configuration)
  - resource "kafka_acl" "producer_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Write" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/account_api_account_atomic_producer" -> null
      - id                           = "User:CN=account-platform/account_api_account_atomic_producer|*|Write|Allow|Topic|account-identity.account.atomic.v1|Literal" -> null
      - resource_name                = "account-identity.account.atomic.v1" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Topic" -> null
    }

Plan: 3 to add, 0 to change, 1 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

@uw-infra
Copy link

uw-infra commented Dec 2, 2024 •
edited
Loading

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: a608c301dfa5dd0e119d9388bd5ac30166e561be
✅ Run Status: Ok, Run Summary: Plan: 2 to add, 0 to change, 1 to destroy. 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.atomic.v1"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.atomic.v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.account_identity_account_api_account_atomic_producer.kafka_acl.producer_acl["account-identity.account.atomic.v1"] will be destroyed
  # (because kafka_acl.producer_acl is not in configuration)
  - resource "kafka_acl" "producer_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Write" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/account_api_account_atomic_producer" -> null
      - id                           = "User:CN=account-platform/account_api_account_atomic_producer|*|Write|Allow|Topic|account-identity.account.atomic.v1|Literal" -> null
      - resource_name                = "account-identity.account.atomic.v1" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Topic" -> null
    }

Plan: 2 to add, 0 to change, 1 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

@matiit matiit requested a review from abramin December 2, 2024 09:45
@matiit matiit merged commit 7d2ea04 into main Dec 2, 2024
2 checks passed
@matiit matiit deleted the acc-954-producer-changes branch December 2, 2024 15:56
@uw-infra
Copy link

uw-infra commented Dec 2, 2024

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: 7d2ea049120e9c92d9f6ae8b43c9786400f3ed0a
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 2 added, 0 changed, 1 destroyed 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.atomic.v1"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.atomic.v1"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.account_identity_account_api_account_atomic_producer.kafka_acl.producer_acl["account-identity.account.atomic.v1"] will be destroyed
  # (because kafka_acl.producer_acl is not in configuration)
  - resource "kafka_acl" "producer_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Write" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/account_api_account_atomic_producer" -> null
      - id                           = "User:CN=account-platform/account_api_account_atomic_producer|*|Write|Allow|Topic|account-identity.account.atomic.v1|Literal" -> null
      - resource_name                = "account-identity.account.atomic.v1" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Topic" -> null
    }

Plan: 2 to add, 0 to change, 1 to destroy.
module.account_identity_account_api_account_atomic_producer.kafka_acl.producer_acl["account-identity.account.atomic.v1"]: Destroying... [id=User:CN=account-platform/account_api_account_atomic_producer|*|Write|Allow|Topic|account-identity.account.atomic.v1|Literal]
module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.events.v2"]: Creating...
module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.atomic.v1"]: Creating...
module.account_identity_account_api_account_atomic_producer.kafka_acl.producer_acl["account-identity.account.atomic.v1"]: Destruction complete after 1s
module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.events.v2"]: Creation complete after 1s [id=User:CN=account-platform/account_api|*|Write|Allow|Topic|account-identity.account.events.v2|Literal]
module.account_identity_account_api.kafka_acl.producer_acl["account-identity.account.atomic.v1"]: Creation complete after 1s [id=User:CN=account-platform/account_api|*|Write|Allow|Topic|account-identity.account.atomic.v1|Literal]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_cert` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 2 added, 0 changed, 1 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarota Jarota Jarota approved these changes

@denisnikulin denisnikulin denisnikulin approved these changes

@abramin abramin Awaiting requested review from abramin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matiit @uw-infra @denisnikulin @abramin @Jarota