Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added kafka topics for cards v2 architecture #703

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Added kafka topics for cards v2 architecture #703

merged 2 commits into from
Nov 20, 2024

Conversation

rafdekar
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Nov 15, 2024

FPAY-1650 [msk] create internal topics for cards

@rafdekar rafdekar marked this pull request as ready for review November 15, 2024 10:03
@rafdekar rafdekar requested a review from a team as a code owner November 15, 2024 10:03
@uw-infra
Copy link

uw-infra commented Nov 15, 2024 •
edited
Loading

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-payment-platform
Path: dev-aws/kafka-shared-msk/payment-platform
Commit ID: 7a8504ecd91327c437413f504e79470103fe3b9e
✅ Run Status: Ok, Run Summary: Plan: 6 to add, 0 to change, 0 to destroy. 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # kafka_topic.card_deadletter_v1_internal will be created
  + resource "kafka_topic" "card_deadletter_v1_internal" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card-deadletter.v1.internal"
      + partitions         = 5
      + replication_factor = 3
    }

  # kafka_topic.card_deadletter_v1_internal_3ds will be created
  + resource "kafka_topic" "card_deadletter_v1_internal_3ds" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card-deadletter.v1.internal.3ds"
      + partitions         = 5
      + replication_factor = 3
    }

  # kafka_topic.card_deadletter_v1_internal_payment_methods will be created
  + resource "kafka_topic" "card_deadletter_v1_internal_payment_methods" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card-deadletter.v1.internal.payment-methods"
      + partitions         = 5
      + replication_factor = 3
    }

  # kafka_topic.card_v1_internal will be created
  + resource "kafka_topic" "card_v1_internal" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card.v1.internal"
      + partitions         = 5
      + replication_factor = 3
    }

  # kafka_topic.card_v1_internal_3ds will be created
  + resource "kafka_topic" "card_v1_internal_3ds" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card.v1.internal.3ds"
      + partitions         = 5
      + replication_factor = 3
    }

  # kafka_topic.card_v1_internal_payment_methods will be created
  + resource "kafka_topic" "card_v1_internal_payment_methods" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card.v1.internal.payment-methods"
      + partitions         = 5
      + replication_factor = 3
    }

Plan: 6 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/payment-platform as comment.

tginszt
tginszt reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@tginszt tginszt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these v1 or v2 topics?
Using v1 flag for the new v2 topics could make it a bit confusing

@rafdekar
Copy link
Contributor Author

are these v1 or v2 topics
These are part of v2 architecture, but are v1 versions of the topics

@rafdekar
Copy link
Contributor Author

Its more related to the proto I guess than to the architecture version

@rafdekar
Copy link
Contributor Author

Proto for the events on the topic is going to be v1, since these events do not exist yet

@rafdekar rafdekar changed the title Added new topics for new cards v2 Added kafka topics for cards v2 architecture Nov 15, 2024
@rafdekar rafdekar merged commit a65c8cd into main Nov 20, 2024
2 checks passed
@rafdekar rafdekar deleted the fpay-1650 branch November 20, 2024 07:41
@uw-infra
Copy link

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-payment-platform
Path: dev-aws/kafka-shared-msk/payment-platform
Commit ID: a65c8cd0968ebaec628958dc88361fbf198892ac
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 6 added, 0 changed, 0 destroyed 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # kafka_topic.card_deadletter_v1_internal will be created
  + resource "kafka_topic" "card_deadletter_v1_internal" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card-deadletter.v1.internal"
      + partitions         = 5
      + replication_factor = 3
    }

  # kafka_topic.card_deadletter_v1_internal_3ds will be created
  + resource "kafka_topic" "card_deadletter_v1_internal_3ds" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card-deadletter.v1.internal.3ds"
      + partitions         = 5
      + replication_factor = 3
    }

  # kafka_topic.card_deadletter_v1_internal_payment_methods will be created
  + resource "kafka_topic" "card_deadletter_v1_internal_payment_methods" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card-deadletter.v1.internal.payment-methods"
      + partitions         = 5
      + replication_factor = 3
    }

  # kafka_topic.card_v1_internal will be created
  + resource "kafka_topic" "card_v1_internal" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card.v1.internal"
      + partitions         = 5
      + replication_factor = 3
    }

  # kafka_topic.card_v1_internal_3ds will be created
  + resource "kafka_topic" "card_v1_internal_3ds" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card.v1.internal.3ds"
      + partitions         = 5
      + replication_factor = 3
    }

  # kafka_topic.card_v1_internal_payment_methods will be created
  + resource "kafka_topic" "card_v1_internal_payment_methods" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "172800000"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "-1"
          + "retention.ms"          = "2592000000"
        }
      + id                 = (known after apply)
      + name               = "payment-platform.card.v1.internal.payment-methods"
      + partitions         = 5
      + replication_factor = 3
    }

Plan: 6 to add, 0 to change, 0 to destroy.
kafka_topic.card_deadletter_v1_internal_3ds: Creating...
kafka_topic.card_v1_internal: Creating...
kafka_topic.card_v1_internal_3ds: Creating...
kafka_topic.card_deadletter_v1_internal_payment_methods: Creating...
kafka_topic.card_v1_internal_payment_methods: Creating...
kafka_topic.card_deadletter_v1_internal: Creating...
kafka_topic.card_deadletter_v1_internal_3ds: Creation complete after 1s [id=payment-platform.card-deadletter.v1.internal.3ds]
kafka_topic.card_v1_internal: Creation complete after 1s [id=payment-platform.card.v1.internal]
kafka_topic.card_v1_internal_3ds: Creation complete after 1s [id=payment-platform.card.v1.internal.3ds]
kafka_topic.card_deadletter_v1_internal_payment_methods: Creation complete after 2s [id=payment-platform.card-deadletter.v1.internal.payment-methods]
kafka_topic.card_deadletter_v1_internal: Creation complete after 2s [id=payment-platform.card-deadletter.v1.internal]
kafka_topic.card_v1_internal_payment_methods: Creation complete after 2s [id=payment-platform.card.v1.internal.payment-methods]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_cert` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 6 added, 0 changed, 0 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/payment-platform as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tginszt tginszt tginszt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafdekar @uw-infra @tginszt