Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bex fulfilment large invoice topics to dev #700

Merged
merged 1 commit into from
Nov 18, 2024
Merged

add bex fulfilment large invoice topics to dev #700

merged 1 commit into from
Nov 18, 2024

Conversation

JDGarner
Copy link
Contributor

@JDGarner JDGarner requested a review from a team as a code owner November 13, 2024 14:42
@uw-infra
Copy link

uw-infra commented Nov 13, 2024 •
edited
Loading

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-customer-billing
Path: dev-aws/kafka-shared-msk/customer-billing
Commit ID: 738baec73dbf0a1956019216a98f5c26a67ab471
✅ Run Status: Ok, Run Summary: Plan: 6 to add, 0 to change, 0 to destroy. 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # kafka_topic.internal_bex_bill_regeneration_large_invoice will be created
  + resource "kafka_topic" "internal_bex_bill_regeneration_large_invoice" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "86400000"
          + "max.message.bytes"     = "1048576"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "8053063680"
          + "retention.ms"          = "259200000"
        }
      + id                 = (known after apply)
      + name               = "bex.internal.bill_regeneration_large_invoice"
      + partitions         = 1
      + replication_factor = 3
    }

  # kafka_topic.internal_bex_fulfilment_large_invoice will be created
  + resource "kafka_topic" "internal_bex_fulfilment_large_invoice" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "86400000"
          + "max.message.bytes"     = "1048576"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "8053063680"
          + "retention.ms"          = "259200000"
        }
      + id                 = (known after apply)
      + name               = "bex.internal.fulfilment_large_invoice"
      + partitions         = 1
      + replication_factor = 3
    }

  # module.invoice_fulfillment.kafka_acl.producer_acl["bex.internal.bill_regeneration_large_invoice"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfillment"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.bill_regeneration_large_invoice"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.invoice_fulfillment.kafka_acl.producer_acl["bex.internal.fulfilment_large_invoice"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfillment"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.fulfilment_large_invoice"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.invoice_fulfillment.kafka_acl.topic_acl["bex.internal.bill_regeneration_large_invoice"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfillment"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.bill_regeneration_large_invoice"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.invoice_fulfillment.kafka_acl.topic_acl["bex.internal.fulfilment_large_invoice"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfillment"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.fulfilment_large_invoice"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 6 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/customer-billing as comment.

@JDGarner JDGarner merged commit e237f78 into main Nov 18, 2024
2 checks passed
@JDGarner JDGarner deleted the add-bex-large-invoice-topic branch November 18, 2024 10:13
@uw-infra
Copy link

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-customer-billing
Path: dev-aws/kafka-shared-msk/customer-billing
Commit ID: e237f7851170778a9f9c39022562e28bd02f56a8
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 6 added, 0 changed, 0 destroyed 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # kafka_topic.internal_bex_bill_regeneration_large_invoice will be created
  + resource "kafka_topic" "internal_bex_bill_regeneration_large_invoice" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "86400000"
          + "max.message.bytes"     = "1048576"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "8053063680"
          + "retention.ms"          = "259200000"
        }
      + id                 = (known after apply)
      + name               = "bex.internal.bill_regeneration_large_invoice"
      + partitions         = 1
      + replication_factor = 3
    }

  # kafka_topic.internal_bex_fulfilment_large_invoice will be created
  + resource "kafka_topic" "internal_bex_fulfilment_large_invoice" {
      + config             = {
          + "cleanup.policy"        = "delete"
          + "compression.type"      = "zstd"
          + "local.retention.ms"    = "86400000"
          + "max.message.bytes"     = "1048576"
          + "remote.storage.enable" = "true"
          + "retention.bytes"       = "8053063680"
          + "retention.ms"          = "259200000"
        }
      + id                 = (known after apply)
      + name               = "bex.internal.fulfilment_large_invoice"
      + partitions         = 1
      + replication_factor = 3
    }

  # module.invoice_fulfillment.kafka_acl.producer_acl["bex.internal.bill_regeneration_large_invoice"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfillment"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.bill_regeneration_large_invoice"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.invoice_fulfillment.kafka_acl.producer_acl["bex.internal.fulfilment_large_invoice"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfillment"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.fulfilment_large_invoice"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.invoice_fulfillment.kafka_acl.topic_acl["bex.internal.bill_regeneration_large_invoice"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfillment"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.bill_regeneration_large_invoice"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.invoice_fulfillment.kafka_acl.topic_acl["bex.internal.fulfilment_large_invoice"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfillment"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.fulfilment_large_invoice"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 6 to add, 0 to change, 0 to destroy.
kafka_topic.internal_bex_fulfilment_large_invoice: Creating...
kafka_topic.internal_bex_bill_regeneration_large_invoice: Creating...
kafka_topic.internal_bex_fulfilment_large_invoice: Creation complete after 1s [id=bex.internal.fulfilment_large_invoice]
kafka_topic.internal_bex_bill_regeneration_large_invoice: Creation complete after 2s [id=bex.internal.bill_regeneration_large_invoice]
module.invoice_fulfillment.kafka_acl.topic_acl["bex.internal.fulfilment_large_invoice"]: Creating...
module.invoice_fulfillment.kafka_acl.producer_acl["bex.internal.bill_regeneration_large_invoice"]: Creating...
module.invoice_fulfillment.kafka_acl.topic_acl["bex.internal.bill_regeneration_large_invoice"]: Creating...
module.invoice_fulfillment.kafka_acl.producer_acl["bex.internal.fulfilment_large_invoice"]: Creating...
module.invoice_fulfillment.kafka_acl.producer_acl["bex.internal.fulfilment_large_invoice"]: Creation complete after 0s [id=User:CN=customer-billing/invoice-fulfillment|*|Write|Allow|Topic|bex.internal.fulfilment_large_invoice|Literal]
module.invoice_fulfillment.kafka_acl.producer_acl["bex.internal.bill_regeneration_large_invoice"]: Creation complete after 0s [id=User:CN=customer-billing/invoice-fulfillment|*|Write|Allow|Topic|bex.internal.bill_regeneration_large_invoice|Literal]
module.invoice_fulfillment.kafka_acl.topic_acl["bex.internal.bill_regeneration_large_invoice"]: Creation complete after 0s [id=User:CN=customer-billing/invoice-fulfillment|*|Read|Allow|Topic|bex.internal.bill_regeneration_large_invoice|Literal]
module.invoice_fulfillment.kafka_acl.topic_acl["bex.internal.fulfilment_large_invoice"]: Creation complete after 0s [id=User:CN=customer-billing/invoice-fulfillment|*|Read|Allow|Topic|bex.internal.fulfilment_large_invoice|Literal]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_cert` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 6 added, 0 changed, 0 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/customer-billing as comment.

@JDGarner JDGarner mentioned this pull request Nov 18, 2024
Merged
JDGarner added a commit that referenced this pull request Nov 18, 2024
@JDGarner
add bex fulfilment large invoice topics to prod (#709)
558fb62 
context -
utilitywarehouse/kubernetes-manifests#99563

dev changes -
#700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrzebykuw mgrzebykuw mgrzebykuw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JDGarner @uw-infra @mgrzebykuw