Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEX-1056] - Create module for deadletter queue job for invoice fulfi… #692

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

agkountis
Copy link
Contributor

…llment.

@agkountis agkountis self-assigned this Nov 8, 2024
@agkountis agkountis requested a review from a team as a code owner November 8, 2024 15:28
Copy link

linear bot commented Nov 8, 2024

@uw-infra
Copy link

uw-infra commented Nov 8, 2024

Terraform run output for

Cluster: prod-aws
Module: pubsub/kafka-shared-msk-customer-billing
Path: prod-aws/kafka-shared-msk/customer-billing
Commit ID: 7328573b8e7b62ebd71922de5e24f6381c8991b3
✅ Run Status: Ok, Run Summary: Plan: 3 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.invoice-fulfilment-dlq-job.kafka_acl.group_acl["bex.invoice-fulfilment-dlq-job"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfilment-dlq-job"
      + id                           = (known after apply)
      + resource_name                = "bex.invoice-fulfilment-dlq-job"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.invoice-fulfilment-dlq-job.kafka_acl.producer_acl["bex.transition.fulfilment_request"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfilment-dlq-job"
      + id                           = (known after apply)
      + resource_name                = "bex.transition.fulfilment_request"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.invoice-fulfilment-dlq-job.kafka_acl.topic_acl["bex.internal.fulfilment_deadletter"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfilment-dlq-job"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.fulfilment_deadletter"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 3 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan prod-aws/kafka-shared-msk/customer-billing as comment.

@uw-infra
Copy link

uw-infra commented Nov 8, 2024

Terraform run output for

Cluster: prod-aws
Module: pubsub/kafka-shared-msk-customer-billing
Path: prod-aws/kafka-shared-msk/customer-billing
Commit ID: 956cb979844de389ba7d91681b8027bc83a2df75
✅ Run Status: Ok, Run Summary: Plan: 3 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.invoice_fulfilment_dlq_job.kafka_acl.group_acl["bex.invoice-fulfilment-dlq-job"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfilment-dlq-job"
      + id                           = (known after apply)
      + resource_name                = "bex.invoice-fulfilment-dlq-job"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.invoice_fulfilment_dlq_job.kafka_acl.producer_acl["bex.transition.fulfilment_request"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfilment-dlq-job"
      + id                           = (known after apply)
      + resource_name                = "bex.transition.fulfilment_request"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.invoice_fulfilment_dlq_job.kafka_acl.topic_acl["bex.internal.fulfilment_deadletter"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfilment-dlq-job"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.fulfilment_deadletter"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 3 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan prod-aws/kafka-shared-msk/customer-billing as comment.

@agkountis agkountis merged commit 00fddf3 into main Nov 8, 2024
2 checks passed
@agkountis agkountis deleted the bex-1056-add-invoice-fulfilment-dql-job-module branch November 8, 2024 16:09
@uw-infra
Copy link

uw-infra commented Nov 8, 2024

Terraform run output for

Cluster: prod-aws
Module: pubsub/kafka-shared-msk-customer-billing
Path: prod-aws/kafka-shared-msk/customer-billing
Commit ID: 00fddf3981ee85ac0766ef67249abcc7f2c29dc4
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 3 added, 0 changed, 0 destroyed
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.invoice_fulfilment_dlq_job.kafka_acl.group_acl["bex.invoice-fulfilment-dlq-job"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfilment-dlq-job"
      + id                           = (known after apply)
      + resource_name                = "bex.invoice-fulfilment-dlq-job"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.invoice_fulfilment_dlq_job.kafka_acl.producer_acl["bex.transition.fulfilment_request"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfilment-dlq-job"
      + id                           = (known after apply)
      + resource_name                = "bex.transition.fulfilment_request"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.invoice_fulfilment_dlq_job.kafka_acl.topic_acl["bex.internal.fulfilment_deadletter"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=customer-billing/invoice-fulfilment-dlq-job"
      + id                           = (known after apply)
      + resource_name                = "bex.internal.fulfilment_deadletter"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 3 to add, 0 to change, 0 to destroy.
module.invoice_fulfilment_dlq_job.kafka_acl.producer_acl["bex.transition.fulfilment_request"]: Creating...
module.invoice_fulfilment_dlq_job.kafka_acl.group_acl["bex.invoice-fulfilment-dlq-job"]: Creating...
module.invoice_fulfilment_dlq_job.kafka_acl.topic_acl["bex.internal.fulfilment_deadletter"]: Creating...
module.invoice_fulfilment_dlq_job.kafka_acl.topic_acl["bex.internal.fulfilment_deadletter"]: Creation complete after 0s [id=User:CN=customer-billing/invoice-fulfilment-dlq-job|*|Read|Allow|Topic|bex.internal.fulfilment_deadletter|Literal]
module.invoice_fulfilment_dlq_job.kafka_acl.group_acl["bex.invoice-fulfilment-dlq-job"]: Creation complete after 0s [id=User:CN=customer-billing/invoice-fulfilment-dlq-job|*|Read|Allow|Group|bex.invoice-fulfilment-dlq-job|Literal]
module.invoice_fulfilment_dlq_job.kafka_acl.producer_acl["bex.transition.fulfilment_request"]: Creation complete after 0s [id=User:CN=customer-billing/invoice-fulfilment-dlq-job|*|Write|Allow|Topic|bex.transition.fulfilment_request|Literal]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_key` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 3 added, 0 changed, 0 destroyed.

To manually trigger plan again please post @terraform-applier plan prod-aws/kafka-shared-msk/customer-billing as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants