Add basic topic config for energy-budget-plan namespace #164
Conversation
| module "budget_plan_fabricator" { | ||
| source = "../../../modules/tls-app" | ||
| consume_topics = { (kafka_topic.eqdb_loader.name) : "energy-budget-plan.eqdb-fabricator-v1" } | ||
| produce_topics = [kafka_topic.customer_change.name] | ||
| cert_common_name = "energy-budget-plan/eqdb-fabricator" | ||
| } |
There was a problem hiding this comment.
The way this is currently built it consumes its own messages. We can change that of course but maybe we add in consume on the customer_change too?
There was a problem hiding this comment.
Sure, can do that while I am here.
There was a problem hiding this comment.
@utilitywarehouse/pubsub do consumer group names have to be unique or can I specify the same consumer group name on different topics?
There was a problem hiding this comment.
Hmmm, this is a good question. The way the tls-app is module is working right now, doing that would create the group_acl resource twice https://github.com/utilitywarehouse/kafka-cluster-config/blob/main/modules/tls-app/main.tf#L13-L21, so I think Terraform would be confused by that.
I'll look into it and see if we can adjust that, but for now I would suggest a different consumer group.
There was a problem hiding this comment.
I've made the consumer groups unique for now.
energy-budget-plan.eqdb-loader,energy-budget-plan.budget-planandenergy-budget-plan.customer-changeenergy-budget-plan.eqdb-loaderenergy-budget-plan.eqdb-loaderand producer onenergy-budget-plan.customer-changeenergy-budget-plan.budget-plan