Add pre-commit config to run terraform fmt
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhughes-uw
force-pushed
the
mhughes-add-terraform-fmt-pre-commit
branch
5 times, most recently
from
5e6ce96 to
08184cf
Compare
matthewhughes-uw
force-pushed
the
mhughes-add-terraform-fmt-pre-commit
branch
from
be4d1bf to
08184cf
Compare
|
Thank you! |
sbuliarca
approved these changes
Feb 8, 2024
Run the hook to format all the code and enforce this via CI to avoid regressions. This is to keep formatting consistent and not a thing to worry/think about when developing or in PRs. This does rely on the local version of `terraform` people are running. I think this can cause issues when running `terraform apply` across different versions, but it should be fine for `terraform fmt` which I can't imagine changes output much between versions.
matthewhughes-uw
force-pushed
the
mhughes-add-terraform-fmt-pre-commit
branch
from
08184cf to
54ff285
Compare
|
merging without the additional approval: the only changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the hook to format all the code and enforce this via CI to avoid
regressions. This is to keep formatting consistent and not a thing to
worry/think about when developing or in PRs.
This does rely on the local version of
terraformpeople are running. Ithink this can cause issues when running
terraform applyacrossdifferent versions, but it should be fine for
terraform fmtwhich Ican't imagine changes output much between versions.