Skip to content

Commit

Permalink
docs: move contributing guidelines to README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
sbuliarca committed Feb 14, 2024
1 parent cb3e67a commit 88e20a1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
1 change: 0 additions & 1 deletion dev-aws/kafka-shared/CONTRIBUTING.md

This file was deleted.

6 changes: 0 additions & 6 deletions prod-aws/kafka-shared/CONTRIBUTING.md

This file was deleted.

7 changes: 5 additions & 2 deletions prod-aws/kafka-shared/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@ Use the [tls-app](../../modules/tls-app) module for granting access for the apps

## Contributing

See [guidelines](CONTRIBUTING.md)
Please follow these guidelines for the resources:
1. topic and consumer groups naming: prefix the names with the name of your team. Examples: **bex.internal.bill_fulfilled**, **bex.bills-total-api-reader** where **bex** is the name of the team.
This will make it easier to define access in the kafka-ui ([dev](https://kafka-ui.dev.merit.uw.systems/) and [prod](https://kafka-ui.prod.merit.uw.systems/) )
2. consider the number of partitions for a topic. In Amazon MSK the total number of partitions influences the cost. See [RFC](https://wiki.uw.systems/posts/amazon-msk-managed-kafka-9kjst9t5#h97za-msk)

## Debugging terraform locally
## pubsub admins: debugging terraform locally

See [instructions](TERRAFORM_LOCALLY.md)

0 comments on commit 88e20a1

Please sign in to comment.