Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIRSHIP-3608 migrate to GHA #47

Merged
merged 5 commits into from
Feb 6, 2024
Merged

AIRSHIP-3608 migrate to GHA #47

merged 5 commits into from
Feb 6, 2024

Conversation

meghaniankov
Copy link
Contributor

No description provided.

@mmcgarr
Copy link
Contributor

mmcgarr commented Feb 5, 2024

I think you will also need to update the Dockerfile for this repo to include --chmod=755 when copying the binary into the image. This is because the upload-artifact and download-artifact steps don't preserve that the binary has executable permissions.

example here
https://github.com/uswitch/yggdrasil/blob/master/Dockerfile#L3

@meghaniankov meghaniankov merged commit 0539607 into master Feb 6, 2024
3 checks passed
@meghaniankov meghaniankov deleted the AIRSHIP-3608-migrate-to-gha branch February 6, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcgarr mmcgarr mmcgarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meghaniankov @mmcgarr