Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storybook build #255

Merged
merged 4 commits into from
Feb 7, 2020
Merged

Fix storybook build #255

merged 4 commits into from
Feb 7, 2020

Conversation

callumacrae
Copy link
Contributor

@callumacrae callumacrae commented Feb 6, 2020 •
edited
Loading

Description

Pretty self-descriptive.

For some reason you might have to delete all your node_modules directories and reinstall to get it to work. No idea why.

This also has the side effect of resolving #214

Checklist

Pull request contains:

  • A new component
  • Component maintenance: improvement / bug fix / etc
  • Component library change: storybook / webpack / etc

Definition of done:

  • PR description includes description of change

@callumacrae callumacrae changed the title [WIP] Fix storybook build Fix storybook build Feb 6, 2020
@callumacrae callumacrae merged commit 527a9ef into master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barneyfoxuk barneyfoxuk barneyfoxuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@callumacrae @barneyfoxuk