Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Updated NIST SP 800-53 Revision 5.1.1 Controls #220

Merged
merged 14 commits into from
Nov 29, 2023

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Nov 9, 2023

Committer Notes

This pull request will update the catalog to the recent release of NIST SP 800-53 Revision 5.1.1 controls.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them? All commits include relevant details about changes
  • Have you written new tests for your core changes, as applicable? N/A
  • Have you included examples of how to use your new feature(s)? N/A

@aj-stein-nist aj-stein-nist self-assigned this Nov 9, 2023
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aj-stein-nist - the new catalog has the same metadata (same root uuid, date, catalog version) with the old one but it was changed and the IA-13 was added plus some editorial changes.

@aj-stein-nist
Copy link
Contributor Author

@aj-stein-nist - the new catalog has the same metadata (same root uuid, date, catalog version) with the old one but it was changed and the IA-13 was added plus some editorial changes.

I was unable to finish work on this last night prior to your review. Expect changes this morning, apologies. This was on the to-do last night I had not completed.

@iMichaela
Copy link
Contributor

@aj-stein-nist - the new catalog has the same metadata (same root uuid, date, catalog version) with the old one but it was changed and the IA-13 was added plus some editorial changes.

I was unable to finish work on this last night prior to your review. Expect changes this morning, apologies. This was on the to-do last night I had not completed.

Perfect. Thank you. I saw the submission of the PR, did not realize it is not ready for review.

@aj-stein-nist aj-stein-nist marked this pull request as ready for review November 14, 2023 21:20
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markup appears all to be consistent - an exacting task, nicely done.

Re-running Schematron one last time indicated the final digit was missing from this UUID.
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the trouble on final-final automated checks, as well.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we discuss the comments? Everything else looks great. Thank you for all this work. I did not have the edits from the RMF team so precise accuracy of the content could not be assessed.

Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and better too, thanks AJ.

@Compton-US Compton-US changed the base branch from develop to feature-800-53-updates November 29, 2023 15:58
@Compton-US Compton-US dismissed iMichaela’s stale review November 29, 2023 16:01

This was resolved.

@Compton-US Compton-US merged commit d6ec10e into feature-800-53-updates Nov 29, 2023
1 check passed
@Compton-US Compton-US deleted the content-updates-5.1.1 branch November 29, 2023 16:03
@Compton-US Compton-US mentioned this pull request Nov 29, 2023
9 tasks
Compton-US pushed a commit that referenced this pull request Dec 5, 2023
* Adding links from assessment objectives to statement items (#147)

* For consistency providing link bindings, making three corrections by hand on label properties (prop[@name='label']:

- 'AC-20a.1' becomes 'AC-20a.01'
- 'AC-20a.2' becomes 'AC-20a.02'
- 'PE-03(01)02]' becomes 'PE-03(01)[02]'

* Adding enhancement XSLT with preliminary result

* Cleanup: updating content, removing preliminary result

* Correcting validation error

* Publish Updated NIST SP 800-53 Revision 5.1.1 Controls (#220)

* Update param AC-07(02)_ODP[02] to use and, not or.

* Param AC-24_ODP[01] to require only one choice.

* Add parens to param CA_02(03)_ODP[01] pluralization

* Limit param CA-08(03)_ODP[02] to 1, not >=1 select

* Change PM-31_ODP[02] and PM-31_ODP[03] param plurals

* Add control IA-13 to catalog.

* Add control enhancement IA-13.1 to catalog.

* Add control enhancement IA-13.2 to catalog.

* IA-13 control and enhancements refs must link back.

* Implementation level and assurance tag for new controls.

* Add FIPS 196 and FIPS 198-1 for IA-13.3 references to back-matter.

* Add IA-13.3, align final edits from RMF Team, and version metadata.

* Fix bad copy-paste on FIPS-196 UUID anchor for IA-13.3 refs

Re-running Schematron one last time indicated the final digit was missing from this UUID.

* Fix revisions, errant link/@rel, and resource title

* Add missing ia-13 links.

* added links for assessment objectives

* contrpl ia-13.3 error fixed

* Per reviewer's comment, replaced depends-on with related-to.

* Updated last-modified and version

* updated rel value to assessment-for per FedRAMP's request

* updated profiles' metadata

* updated profiles' root uuid

---------

Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: Iorga <[email protected]>
Co-authored-by: Iorga <[email protected]>
@Compton-US Compton-US mentioned this pull request Dec 5, 2023
7 tasks
Compton-US pushed a commit that referenced this pull request Dec 5, 2023
* Adding links from assessment objectives to statement items (#147)

* For consistency providing link bindings, making three corrections by hand on label properties (prop[@name='label']:

- 'AC-20a.1' becomes 'AC-20a.01'
- 'AC-20a.2' becomes 'AC-20a.02'
- 'PE-03(01)02]' becomes 'PE-03(01)[02]'

* Adding enhancement XSLT with preliminary result

* Cleanup: updating content, removing preliminary result

* Correcting validation error

* Publish Updated NIST SP 800-53 Revision 5.1.1 Controls (#220)

* Update param AC-07(02)_ODP[02] to use and, not or.

* Param AC-24_ODP[01] to require only one choice.

* Add parens to param CA_02(03)_ODP[01] pluralization

* Limit param CA-08(03)_ODP[02] to 1, not >=1 select

* Change PM-31_ODP[02] and PM-31_ODP[03] param plurals

* Add control IA-13 to catalog.

* Add control enhancement IA-13.1 to catalog.

* Add control enhancement IA-13.2 to catalog.

* IA-13 control and enhancements refs must link back.

* Implementation level and assurance tag for new controls.

* Add FIPS 196 and FIPS 198-1 for IA-13.3 references to back-matter.

* Add IA-13.3, align final edits from RMF Team, and version metadata.

* Fix bad copy-paste on FIPS-196 UUID anchor for IA-13.3 refs

Re-running Schematron one last time indicated the final digit was missing from this UUID.

* Fix revisions, errant link/@rel, and resource title

* Add missing ia-13 links.

* added links for assessment objectives

* contrpl ia-13.3 error fixed

* Per reviewer's comment, replaced depends-on with related-to.

* Updated last-modified and version

* updated rel value to assessment-for per FedRAMP's request

* updated profiles' metadata

* updated profiles' root uuid

---------

Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: Iorga <[email protected]>
Co-authored-by: Iorga <[email protected]>
Compton-US pushed a commit that referenced this pull request Dec 5, 2023
* Feature 800 53 updates (#221)

* Adding links from assessment objectives to statement items (#147)

* For consistency providing link bindings, making three corrections by hand on label properties (prop[@name='label']:

- 'AC-20a.1' becomes 'AC-20a.01'
- 'AC-20a.2' becomes 'AC-20a.02'
- 'PE-03(01)02]' becomes 'PE-03(01)[02]'

* Adding enhancement XSLT with preliminary result

* Cleanup: updating content, removing preliminary result

* Correcting validation error

* Publish Updated NIST SP 800-53 Revision 5.1.1 Controls (#220)

* Update param AC-07(02)_ODP[02] to use and, not or.

* Param AC-24_ODP[01] to require only one choice.

* Add parens to param CA_02(03)_ODP[01] pluralization

* Limit param CA-08(03)_ODP[02] to 1, not >=1 select

* Change PM-31_ODP[02] and PM-31_ODP[03] param plurals

* Add control IA-13 to catalog.

* Add control enhancement IA-13.1 to catalog.

* Add control enhancement IA-13.2 to catalog.

* IA-13 control and enhancements refs must link back.

* Implementation level and assurance tag for new controls.

* Add FIPS 196 and FIPS 198-1 for IA-13.3 references to back-matter.

* Add IA-13.3, align final edits from RMF Team, and version metadata.

* Fix bad copy-paste on FIPS-196 UUID anchor for IA-13.3 refs

Re-running Schematron one last time indicated the final digit was missing from this UUID.

* Fix revisions, errant link/@rel, and resource title

* Add missing ia-13 links.

* added links for assessment objectives

* contrpl ia-13.3 error fixed

* Per reviewer's comment, replaced depends-on with related-to.

* Updated last-modified and version

* updated rel value to assessment-for per FedRAMP's request

* updated profiles' metadata

* updated profiles' root uuid

---------

Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: Iorga <[email protected]>
Co-authored-by: Iorga <[email protected]>

* Adjust home repository to oscal-content

---------

Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: Iorga <[email protected]>
Co-authored-by: Iorga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants