Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Schema generation improvements #108

Merged
merged 19 commits into from
Jun 7, 2024
Merged

JSON Schema generation improvements #108

merged 19 commits into from
Jun 7, 2024

Conversation

wendellpiez
Copy link
Collaborator

@wendellpiez wendellpiez commented Mar 7, 2024 •
edited
Loading

Committer Notes

Addresses #105.

This PR should contain not only modifications to JSON Schema generation, but unit tests and testing to verify this production from Metaschema sources.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024 •
edited
Loading

XSpec Test Results

  4 files  + 2   44 suites  +4   0s ⏱️ ±0s
115 tests +10   99 ✅ +9  16 💤 +1  0 ❌ ±0 
124 runs  +10  108 ✅ +9  16 💤 +1  0 ❌ ±0 

Results for commit 89838bb. ± Comparison against base commit 04a4a4c.

♻️ This comment has been updated with latest results.

This was referenced Mar 11, 2024
Open
Open
Closed
@wandmagic
Copy link
Contributor

have to select a json schema validator
i prefer ajv-cli

@iMichaela iMichaela mentioned this pull request Mar 30, 2024
Open
@wendellpiez wendellpiez mentioned this pull request Apr 1, 2024
Closed
3 tasks
@wendellpiez
Copy link
Collaborator Author

Add to this work item: analyze and repair the JSON Schema lapse described here:

usnistgov/OSCAL#2007

It may be only the markup datatypes that are failing to be resolved down 'to the bottom'.

@wendellpiez wendellpiez marked this pull request as ready for review June 4, 2024 21:07
@wendellpiez wendellpiez requested a review from a team as a code owner June 4, 2024 21:07
@wendellpiez wendellpiez mentioned this pull request Jun 5, 2024
Merged
8 tasks
@wendellpiez
Mainly planning, some scripting
86cbeed
@wendellpiez
Now with XSpecs running over JSON Schema generation - showing a succe…
9997f2b 
…ssful run and framing for demonstrating any current functional lapses -
@wendellpiez
Progress toward field testing of XSD and JSON Schema in application
7d91622
@wendellpiez
Preliminary implementation of 'choice' breakout
c48080f
@wendellpiez
Now adding XSD and Schematron validation supporting a PR-time validat…
0e785ab 
…ion check on input dependencies - it is replicable
@wendellpiez
Now more better support of JSON Schema field testing, with document p…
15074a6 
…roof sets
@wendellpiez
Rearranging submodules; catching up with JSON schema modeling issue
5810d2c
@wendellpiez
Restoring schxslt b/c we need it after all (while using it under XPro…
048b85a 
…c 1.0)
@wendellpiez
Repair addressing usnistgov#105 (failure to honor 'choice' semantics)…
837a42b 
…, still wanting testing; with a small testing application
@wendellpiez wendellpiez force-pushed the issue105-jsonschemaA branch from 7c840c8 to 837a42b Compare June 5, 2024 13:52
@wendellpiez wendellpiez marked this pull request as draft June 6, 2024 15:10
@wendellpiez
Copy link
Collaborator Author

Changing this back to Draft since -

So the first thing is to point this PR not at develop but an integration branch, right?

@wendellpiez wendellpiez changed the base branch from develop to merge-June2024 June 7, 2024 13:02
@wendellpiez wendellpiez marked this pull request as ready for review June 7, 2024 13:04
@wendellpiez wendellpiez merged commit 24e5007 into usnistgov:merge-June2024 Jun 7, 2024
3 checks passed
wendellpiez added a commit that referenced this pull request Aug 30, 2024
@wendellpiez
Testing and repairs including JSON Schema generation enhancements (#119)
b63b373 
* produce-xml-converter.xsl: XSpec tests and minor XSLT improvements (#87)
* XSpec tests and minor XSLT improvements
* JSON Schema generation improvements (#108) Refactoring submodules; XProc-based testing; XSpec testing of JSON Schema generation; improvements to JSON Schema generation - addressing #105 also #2007.
* June 2024 Integration (#118) Integrating branches
* June 2024 in-progress merge (#120) Includes updates to unit testing, Inspector XSLT, JSON Schema (#105) and others
* More testing (#122) Mostly testing support -
* Adding Makefile in compose phase to run XSpec - presently showing errors!
* Extending and reorganizing testing, including removing temporary artifacts from git
* Adding subpipeline mistakenly omitted from the last PR
* New Makefile for testing/tinydata
* Mending XSpecs testing Metaschema composition (regression protection); also a new tinydata sample.
* Update src/testing/tinydata/tiny-data/terms-of-art.xml (AJ Stein)
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Amanda Galtman <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendellpiez @wandmagic