Skip to content

Commit

Permalink
Fix unselected control handling for #232
Browse files Browse the repository at this point in the history
This may be a business logic error or perhaps at one time there was/is
a valid reason, but as it stands the BasicIndexer would detect
unselected controls for resolution of the profile but only drop them
when their parent was selected for the default strategy of flattening.
For simple trees where c1 is the root control and c1.1 is the child, so
c1 -> c1.1, c1 was not being correctly removed.

NOTE: Logging indicates a double index of c1.1 even with this change
so that still needs to be fixed most likely to resolve this issue.
  • Loading branch information
aj-stein-nist committed Feb 1, 2024
1 parent 5ef9291 commit 19e4ca4
Showing 1 changed file with 10 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,14 @@ public Collection<IEntityItem> getEntitiesByItemType(@NonNull IEntityItem.ItemTy
return entityGroup == null ? CollectionUtil.emptyList() : ObjectUtils.notNull(entityGroup.values());
}
//
// public EntityItem getEntity(@NonNull ItemType itemType, @NonNull UUID identifier) {
// return getEntity(itemType, ObjectUtils.notNull(identifier.toString()), false);
// public EntityItem getEntity(@NonNull ItemType itemType, @NonNull UUID
// identifier) {
// return getEntity(itemType, ObjectUtils.notNull(identifier.toString()),
// false);
// }
//
// public EntityItem getEntity(@NonNull ItemType itemType, @NonNull String identifier) {
// public EntityItem getEntity(@NonNull ItemType itemType, @NonNull String
// identifier) {
// return getEntity(itemType, identifier, itemType.isUuid());
// }

Expand Down Expand Up @@ -327,10 +330,11 @@ protected final AbstractEntityItem.Builder newBuilder(
/**
* Create a new builder with the provided info.
* <p>
* This method can be overloaded to support applying additional data to the returned builder.
* This method can be overloaded to support applying additional data to the
* returned builder.
* <p>
* When working with identifiers that are case insensitve, it is important to ensure that the
* identifiers are normalized to lower case.
* When working with identifiers that are case insensitve, it is important to
* ensure that the identifiers are normalized to lower case.
*
* @param item
* the Metapath node to associate with the entity
Expand Down

0 comments on commit 19e4ca4

Please sign in to comment.