Fixed issue with scalebar drawing off bottom of screen in fullscreen mode #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting a toolbar element external to OSD, the bottom left or bottom right scalebar gets drawn off bottom of page, this commit fixes that issue by checking for a toolbar element, and subtracting the offsetheight of the toolbar element from the y position of the scalebar
If openseadragon had a toolbar element specified (e.g. outside of viewer window), then in fullscreen mode, scalebar on bottom_left or bottom_right would draw off bottom of page (since toolbar is drawn at the top). Fixed this issue by checking for OSD toolbar and fullscreen, and subtracting toolbar height from y position of scalebar in bottom_left or bottom_right positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user set an external toolbar to openseadragon, then the scalebar would draw off bottom of the page in fullscreen mode (if BOTTOM_LEFT or BOTTOM_RIGHT position specified) because openseadragon adds the toolbar to the top of the page.