Adjusted language for metadata:last-modified
#1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-stein-nist
suggested changes
Aug 25, 2023
There was a problem hiding this comment.
Thanks for picking this up and doing a quick, effective job. I do think we should change tact with this, however, let me know what you think. I am open to feedback from you @nikitawootten-nist (and @wendellpiez as he reviewed it and has contributed a lot to the spec past and present).
src/specifications/profile-resolution/profile-resolution-specml-requirements.xspec
Outdated
Show resolved
Hide resolved
src/specifications/profile-resolution/profile-resolution-specml-working.xml
Outdated
Show resolved
Hide resolved
src/specifications/profile-resolution/profile-resolution-specml.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: A.J. Stein <[email protected]>
I like this wording better, thanks! |
aj-stein-nist
approved these changes
Aug 25, 2023
nikitawootten-nist
added a commit
to nikitawootten-nist/OSCAL-Pages
that referenced
this pull request
Aug 25, 2023
aj-stein-nist
pushed a commit
to usnistgov/OSCAL-Pages
that referenced
this pull request
Aug 29, 2023
aj-stein-nist
added a commit
that referenced
this pull request
Sep 12, 2023
* Adjusted language for `metadata:last-modified` * Apply suggestions from code review Co-authored-by: A.J. Stein <[email protected]> --------- Co-authored-by: A.J. Stein <[email protected]>
Arminta-Jenkins-NIST
pushed a commit
that referenced
this pull request
Sep 12, 2023
* Adjusted language for `metadata:last-modified` * Apply suggestions from code review Co-authored-by: A.J. Stein <[email protected]> --------- Co-authored-by: A.J. Stein <[email protected]>
Arminta-Jenkins-NIST
pushed a commit
to usnistgov/OSCAL-Pages
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Fixes #1699
NOTE: This PR will require a follow-up PR in OSCAL-Pages to replicate the change. All spec changes will require manual replication until the responsibility of spec generation is moved to the OSCAL-Reference repo: usnistgov/OSCAL-Reference#16.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)