Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional control-origination props #784 #1456

Conversation

Compton-US
Copy link
Contributor

@Compton-US Compton-US commented Sep 15, 2022

Committer Notes

Based on the request in #784, extended the xpath to include control-origination props for:

implemented-requirement/prop
implemented-requirement/by-component/prop
implemented-requirement/statement/prop
implemented-requirement/statement/by-component/prop

The updated xpath selected the following paths from my test case:

" /system-security-plan[1]/control-implementation[1]/implemented-requirement[1]/prop[1]/@name",
" /system-security-plan[1]/control-implementation[1]/implemented-requirement[1]/prop[2]/@name",
" /system-security-plan[1]/control-implementation[1]/implemented-requirement[1]/prop[3]/@name",
" /system-security-plan[1]/control-implementation[1]/implemented-requirement[1]/statement[1]/prop[1]/@name",
" /system-security-plan[1]/control-implementation[1]/implemented-requirement[1]/statement[2]/by-component[1]/prop[1]/@name",
" /system-security-plan[1]/control-implementation[1]/implemented-requirement[2]/prop[1]/@name",
" /system-security-plan[1]/control-implementation[1]/implemented-requirement[2]/prop[2]/@name",
" /system-security-plan[1]/control-implementation[1]/implemented-requirement[2]/prop[3]/@name",
" /system-security-plan[1]/control-implementation[1]/implemented-requirement[2]/by-component[1]/prop[1]/@name",

A note was added that the child context will override the parent control-origination.

Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know Dave has the final sign-off, but I did review (as part of the assigned group for the issue) and looks all good to me (barring the broken link, but there is a separate PR to fix that against develop as discussed last week).

@aj-stein-nist aj-stein-nist linked an issue Sep 19, 2022 that may be closed by this pull request
5 tasks
@aj-stein-nist
Copy link
Contributor

@Compton-NIST if you pull in from current develop as of this morning, the link check tests will pass. Thanks for your help late last week.

@Compton-US Compton-US closed this Sep 19, 2022
@Compton-US Compton-US deleted the ssp-prop-control-origination-issue-784 branch September 19, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSP Control Implementation Scope/Origination
2 participants