Skip to content

Commit

Permalink
Use pandas 2.1.4 for diff.
Browse files Browse the repository at this point in the history
2.2.0 introduces a regression in the use of melt that this script
relies on.
  • Loading branch information
gfiumara committed Mar 8, 2024
1 parent 01dfc7d commit 9ac3c29
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-member.yml
Original file line number Diff line number Diff line change
Expand Up @@ -239,5 +239,5 @@ jobs:
working-directory: ${{ github.workspace }}/conformance
shell: bash
run: |
python -m pip install pandas packaging
python -m pip install pandas==2.1.4 packaging
python ./diff.py -s conformance_expected_output.csv github.csv
2 changes: 1 addition & 1 deletion .github/workflows/run-cts-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ jobs:
- name: Diff Conformance Test
shell: bash
run: |
python -m pip install pandas packaging
python -m pip install pandas==2.1.4 packaging
python conformance/diff.py -s conformance/conformance_expected_output.csv github.csv
- name: Upload conformance output artifact
Expand Down
7 changes: 7 additions & 0 deletions conformance/diff.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@
print("This script requires the use of Pandas v1.1.0.")
sys.exit(1)

# melt() with a MultiIndex is not working as of 2.2.0. Force use of an earlier
# version for now until the regression is corrected or we fix this script.
# See: https://github.com/pandas-dev/pandas/issues/57663
if Version(pd.__version__) >= Version("2.2.0"):
print("This script does not support Pandas v2.2.0.")
sys.exit(1)

# Argument parser
parser = argparse.ArgumentParser()
parser.add_argument("csv1", type = str, help="First CSV")
Expand Down

0 comments on commit 9ac3c29

Please sign in to comment.