Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USH-1684 - Edit posts with old image fields #1478

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

ushahidlee
Copy link
Contributor

Issue:

When editing posts that have the old image field, but do not have an image uploaded, the user cannot save the edit due to an error around caption being missing.

Solution:

This PR adds better sanity checking in the old code, to prevent these errors from occurring. It also fixes some unreported issues around deleting and replacing images.

Testing:

  1. Create a post with a survey that has the old image field, but do not upload any images.
  2. Edit that post, without modifying the image field (no image or caption).
  3. It will save changes successfully.

Copy link

linear bot commented Nov 21, 2024

Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woop!

@ushahidlee ushahidlee merged commit 4e9ec7e into development Nov 21, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants