Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add json marshal for v1beta1 tasks #269

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Nov 6, 2024

Just a quick fix for v1beta1 tasks marshaling for backwards compatibility

@tobybellwood tobybellwood marked this pull request as ready for review November 6, 2024 23:59
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against v1 tasks and v2 builds ok - cleans up as expected

2024-11-06T08:55:28Z	INFO	v1beta1.LagoonTask	lagoon-task-vi4eey found in namespace drupal9-base-main is no longer required, removing it. v1alpha1 is deprecated in favor of v1beta1	{"lagoontask": {"name":"lagoon-task-vi4eey","namespace":"drupal9-base-main"}}

@tobybellwood tobybellwood merged commit b65633a into main Nov 7, 2024
10 checks passed
@tobybellwood tobybellwood deleted the v1task-marshal branch November 7, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants