feat: introduce new retain harbor resources labels and deprecate old ones #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This introduces new retaining labels that can be added to the harbor secret, or the namespace, that will inform the deletion handler to not clean up resources in harbor when a namespace is deleted.
The following labels can now be added to the namespace or the internal registry secret that Lagoon uses to prevent resources being deleted in harbor when a namespace is deleted in kubernetes. This would mostly used if you're migrating an environment between two clusters that may share the same harbor. If they're different harbors, then you probably don't need to use these at all.
harbor.lagoon.sh/retain-repositories
harbor.lagoon.sh/retain-robotaccount
These two labels were created for this purpose initially. These labels are now deprecated, and you should use the new ones
harbor.lagoon.sh/cleanup-repositories
harbor.lagoon.sh/cleanup-robotaccount