Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update group docs to describe subgroups and inherited roles #3824

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

smlx
Copy link
Member

@smlx smlx commented Oct 11, 2024

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

This PR adds documentation which briefly describes subgroups and how they work with permissions in Lagoon.

Closing issues

n/a

@smlx smlx added the 7-documentation-examples Documentation & Examples / DX subsystem label Oct 11, 2024
@smlx smlx requested a review from tobybellwood October 14, 2024 02:59

A user's role in an ancestor group is inherited by descendant groups.

## Subgroups example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Subgroups example
## Subgroups explainer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that "explainer" is clearer than "example" (is it even a word?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to deter people from creating them - as there's no guarantee that it'll be something Lagoon always supports - ad they introduce a lot of complexity that is better resolved elsewhere. Rather than telling people how to create them, I wanted to explain how they work when inherited (eg via gitlab sync)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no guarantee that it'll be something Lagoon always supports - ad they introduce a lot of complexity that is better resolved elsewhere

Should we say that directly in this section then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the title of the section to hopefully be clearer, and also enhanced the warning on the page. Let me know if that is any better?

Comment on lines +18 to +20
Groups can be nested to an arbitrary depth.
Subgroups are groups which are a child of another group.

Copy link
Member

@tobybellwood tobybellwood Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Groups can be nested to an arbitrary depth.
Subgroups are groups which are a child of another group.
Subgroups cannot be created or managed via the UI or the CLI; they will only be created via the legacy automated user sync tooling.
Groups can be nested to an arbitrary depth.
Subgroups are groups that are a child of another group.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can be created via the API, but not the CLI

Subgroups cannot be created or managed via the UI or the API

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I knew I wasn't the only one confused about subgroups!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note, hopefully that helps?

@tobybellwood
Copy link
Member

Added a couple of updates to highlight just how rare these are, and to explain the complexities of dealing with them.

* fix typo
* clean up diagram
* enhance warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-documentation-examples Documentation & Examples / DX subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants