Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: last_accessed on user noops #3762

Merged
merged 1 commit into from
Jul 3, 2024
Merged

refactor: last_accessed on user noops #3762

merged 1 commit into from
Jul 3, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Last accessed is a bit racy still, so just noop them for now, we can refactor later.
Alternative approach is a user table in #3761

@shreddedbacon shreddedbacon added this to the 2.20.0 milestone Jul 3, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review July 3, 2024 21:54
tobybellwood
tobybellwood approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will reconsider #3761 as part of a larger "user/audit" piece of work. Happy to merge this

@tobybellwood tobybellwood merged commit a873bb8 into main Jul 3, 2024
1 check passed
@shreddedbacon shreddedbacon deleted the refactor-last-accessed-noop branch July 3, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood