Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Extends allNotifications with optional filters #3740

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CGoodwin90
Copy link
Contributor

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Extends allNotifications to have an optional name & type input.

@CGoodwin90 CGoodwin90 marked this pull request as draft June 13, 2024 00:09
@CGoodwin90 CGoodwin90 marked this pull request as ready for review June 13, 2024 06:04
@shreddedbacon shreddedbacon added this to the 2.21.0 milestone Jul 4, 2024
@shreddedbacon shreddedbacon force-pushed the extend-allNotifications branch from 6876943 to e2c246d Compare September 8, 2024 22:56
@shreddedbacon
Copy link
Member

Just re-based and pushed (didn't change any code) before finalising review

@shreddedbacon shreddedbacon force-pushed the extend-allNotifications branch from e2c246d to c90f58b Compare September 9, 2024 00:57
@shreddedbacon
Copy link
Member

This works fine, but I'm wondering if this is the best approach to this now.

The name and type filters are nice, but I don't know if this is something that is really useful for anyone that isn't a platform-owner. Type is also sort of irrelevant because of the way the resolver works with fragments.

With organizations also being a thing, the likelihood of someone using this that isn't a platform-owner is probably low.

I can't recall if there was a specific reason for these changes or not though, but maybe we can get away without this change for now?

@CGoodwin90
Copy link
Contributor Author

This works fine, but I'm wondering if this is the best approach to this now.

The name and type filters are nice, but I don't know if this is something that is really useful for anyone that isn't a platform-owner. Type is also sort of irrelevant because of the way the resolver works with fragments.

With organizations also being a thing, the likelihood of someone using this that isn't a platform-owner is probably low.

I can't recall if there was a specific reason for these changes or not though, but maybe we can get away without this change for now?

It was just so we had a way to retrieve unassigned notifications, right now once created they're essentially lost to the void until assigned to a project. I think there were some commands in the cli where this might be useful, but not super necessary. Happy to proceed without it for now though.

@shreddedbacon
Copy link
Member

It was just so we had a way to retrieve unassigned notifications, right now once created they're essentially lost to the void until assigned to a project. I think there were some commands in the cli where this might be useful, but not super necessary. Happy to proceed without it for now though.

Ahh that's right. Yeah, I think it might need some adjustments, so maybe we can bump this to 2.22.0 instead. I'll add some review comments with some suggested changes.

@shreddedbacon shreddedbacon modified the milestones: 2.21.0, 2.22.0 Sep 9, 2024
@tobybellwood tobybellwood modified the milestones: 2.22.0, 2.23.0 Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants