Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add notice about planned harbor deprecations #3614

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Just adding some notices about planned old Harbor version deprecation. The code in the API is already basically abandoned and likely doesn't work reliably for anyone using Harbor 2.2.x+. And retaining the code base in the remote-controller means retaining a forked client library, for which the newer library doesn't require a fork.

This would allow us to proceed with cleaning up old code in a future release, here are some existing PRs that could be merged then.

@shreddedbacon shreddedbacon marked this pull request as ready for review December 11, 2023 03:33
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy with these, flagging them for people's attention.

@tobybellwood tobybellwood merged commit cf4508e into main Dec 11, 2023
1 check passed
@shreddedbacon shreddedbacon deleted the harbor-support branch December 11, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants