Avoid a cron job running concurrently with itself #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the time taken for the cronjob to run is longer than the period between jobs you can end up with dozens of cronjob processes running inside the pod. Since we already wrap the cron command, just add some locking to it so that only one instance of a cron job can run at once.
|
Not sure if this change is tested in CI. Is this issue still valid? uselagoon/lagoon#2462 |
|
digging into this, lagoon/cronjob.sh is only called for kubernetes-initiated cronjobs, which always run in their own pod, and rely on k8s to remove concurrency, so this flock won't apply to them. In-pod cronjobs are controlled by the entrypoint at 90-cronjobs.sh running go-crond, so maybe that's where the flock needs inserting? |
|
Ah of course! Thanks for pointing that out. This PR doesn't make sense, so I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the time taken for the cronjob to run is longer than the period between jobs you can end up with dozens of cronjob processes running inside the pod.
Since we already wrap the cron command, just add some locking to it so that only one instance of a cron job can run at once.
Closes: #172
Closes: uselagoon/lagoon#2399