chore: ignore chart version bump, dont publish charts if tag exists #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
chart-releasing
branch
from
b0f98c6 to
4757aa9
Compare
shreddedbacon
force-pushed
the
chart-releasing
branch
from
4757aa9 to
1313611
Compare
|
yes - this gives us the flexibility we need - having long-running release branches requires too much manual handling of variable overrides, and this should clear things up. In 2025, we'll re-evaluate Lagoon versioning/numbering, and having a clear strategy for chart releases will make this easier. |
tobybellwood
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our process to skirt the chart increment requirement is to create a feature branch in this repository (eg #694), then make changes to other repositories (eg uselagoon/lagoon#3826). Once this feature branch is merged, we have to revert the changes in other repositories (eg uselagoon/lagoon#3842). This is quite frustrating, and has lead to issues after a release when tests start failing because of some reference that wasn't reverted, or was reverted incorrectly. All could have been avoided if we just continued merging to main and released the chart when we were ready to do so.
The govuk team have described similar frustrations with this enforcement here. While they said they're using ArgoCD, this appears to be similar to how we're consuming the
mainbranch of charts in theuselagoon/lagoonrepository where the version of the chart does not matter.What these changes allow us to do is:
The act of bumping a chart version will still create and publish that chart. This means when it makes sense to release, or the changes are small patches that can be released in isolation, the existing process can still be followed.
Additionally included a (hopefully working) artifacthub linter, to try and catch issues relating to formatting in the artifacthub change logs that bit us recently.