feat: add sysctl configure daemonset #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
lagoon-remote-sysctl-configure
branch
from
f3d19e8 to
4b154cd
Compare
shreddedbacon
force-pushed
the
lagoon-remote-sysctl-configure
branch
3 times, most recently
from
67e4261 to
e867e78
Compare
shreddedbacon
force-pushed
the
lagoon-remote-sysctl-configure
branch
from
e867e78 to
37d8726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove https://github.com/uselagoon/build-deploy-tool/blob/d2508efa74871cabe4c477e44bbe87e339d99f5d/internal/servicetypes/opensearch.go#L75-L96 from the opensearch and elasticsearch templates so that no containers require the
privileged: truevalue. There needs to be some option to configure any sysctl values as required inlagoon-remote.This adds a
DaemonSetthat allows for setting this value, and potentially other values. This is disabled by default.Ideally the underlying instances that run kubernetes should have the values updated to remove the need for this, but in cases where it isn't possible to do so, this
DaemonSetprovides the capability.Linked to uselagoon/build-deploy-tool#395