Always create sshPortal authorization resources and add a service account token resource #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount token resource
|
The documentation for the k8s API used in this PR is here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#manually-create-an-api-token-for-a-serviceaccount Could we put the creation of this secret behind a flag so that people have to understand the step they are taking with this? e.g. maybe a top-level |
|
Superseded by #608 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to keep the legacy SSH service in lagoon-core working in recent k8s clusters, a non-expiring token is needed. A sufficiently scoped role and binding already exists for the ssh-portal, so this PR adds the service account token secret that can be used in lagoon-core. Since this is needed even if ssh-portal isn't used, the auth related resources are changed to always be created, even if the ssh-portal service isn't enabled.