Skip to content

Commit

Permalink
Merge pull request #645 from uselagoon/legacy-registry-passthrough-su…
Browse files Browse the repository at this point in the history
…pport

chore: add legacy registry passthrough support
  • Loading branch information
tobybellwood authored Mar 13, 2024
2 parents b45b6fd + c2ad08a commit 924568b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
6 changes: 3 additions & 3 deletions charts/lagoon-build-deploy/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ kubeVersion: ">= 1.23.0-0"

type: application

version: 0.26.3
version: 0.26.4

appVersion: v0.15.4
appVersion: v0.15.5

annotations:
artifacthub.io/changes: |
- kind: changed
description: added clusterroles for tasks and builds
description: added legacy registry passthrough support
3 changes: 3 additions & 0 deletions charts/lagoon-build-deploy/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,9 @@ spec:
{{- with .Values.timeoutForLongRunningTaskPods }}
- "--timeout-longrunning-task-pod-cleanup={{ . }}"
{{- end }}
{{- with .Values.unauthenticatedRegistry }}
- "--unauthenticated-registry={{ . }}"
{{- end }}
{{- with .Values.extraArgs }}
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
4 changes: 4 additions & 0 deletions charts/lagoon-build-deploy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ rabbitMQHostname: ""
rabbitMQPassword: ""
rabbitMQUsername: ""

# This is here due to the removal of the passthrough from core https://github.com/uselagoon/lagoon/pull/3659
# if you leveraged this value in your core, you should ensure you update your remotes with this value to reflect what you previously had provided in core
# unauthenticatedRegistry: registry.lagoon.svc:5000

# NOTE!! lagoon api/host/port values if left empty fall back to the task api/host/port values
# taskSSHHost/lagoonTokenHost is the hostname for the lagoon token service
# taskSSHHost will be deprecated in favor of lagoonTokenHost
Expand Down

0 comments on commit 924568b

Please sign in to comment.