Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add github action to run test-e2e #6

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Apr 29, 2024

Updates to the Makefile to include creating a kind cluster locally for running e2e tests

Renamed the make commands to be github/test-e2e and local-kind/test-e2e

Use local-kind/test-e2e to handle creating the kind cluster to ensure that the cluster exists before running the tests over it

@shreddedbacon shreddedbacon force-pushed the gh-actions branch 4 times, most recently from 0b160f1 to c73644c Compare April 30, 2024 00:24
@shreddedbacon shreddedbacon changed the title test: add gh action test: add github action to run test-e2e Apr 30, 2024
@shreddedbacon shreddedbacon requested a review from domcyrus April 30, 2024 06:10
@shreddedbacon
Copy link
Member Author

shreddedbacon commented Apr 30, 2024

I noticed that the kind cluster is hardcoded in the e2e tests in places, would be nice if this could be configurable somehow, but I wasn't sure how to do that so I've left all the clusternames for the kind to be created as kind still.

https://github.com/uselagoon/dbaas-controller/blob/gh-actions/test/utils/utils.go#L137-L146 < I think this? So maybe can just set the envvar KIND_CLUSTER and that solves the problem?

@domcyrus
Copy link

Nice @shreddedbacon ! yeah I think the KIND_CLUSTER env var can be used to set it. It's not documented anywhere in the kubebuilder repo but I think it should be fine.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Co-authored-by: Marco Cadetg <[email protected]>
@shreddedbacon shreddedbacon merged commit dcf07dc into main May 3, 2024
1 check passed
@shreddedbacon shreddedbacon deleted the gh-actions branch May 3, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants