Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add latest tag build and push #8

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Feat: Add latest tag build and push #8

merged 2 commits into from
Nov 29, 2023

Conversation

steveworley
Copy link
Contributor

  • Adds support to build :latest tags
  • Adds a new flag to toggle date base image tags

shreddedbacon
shreddedbacon requested changes Nov 29, 2023
View reviewed changes
mariadb-image-builder Outdated Show resolved Hide resolved
@shreddedbacon shreddedbacon changed the title Feat: Add latest tag build and push. Feat: Add latest tag build and push Nov 29, 2023
shreddedbacon
shreddedbacon approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action is failing because of unrelated reasons. This looks good now though

@shreddedbacon shreddedbacon merged commit 68e5732 into uselagoon:main Nov 29, 2023
1 check failed
@tobybellwood
Copy link
Member

The action is failing because of unrelated reasons. This looks good now though

yah - the DOCKERHUB secrets aren't passed to PR runs - we could try and skip the docker push for PRs (and only do a ghcr one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveworley @tobybellwood @shreddedbacon