-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing database name 1 #13
Merged
shreddedbacon
merged 3 commits into
uselagoon:main
from
tnelson-doghouse:passing-database-name-1
Nov 22, 2024
Merged
Passing database name 1 #13
shreddedbacon
merged 3 commits into
uselagoon:main
from
tnelson-doghouse:passing-database-name-1
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purpose ------- - To allow the passing of the MTK_DUMP_* variables into the task in one way or another, rather than assuming that the database is going to be the one in the Lagoon service - Also instead allow the passing of the name of a variable that contains the MTK_DUMP_* value. For example, MTK_DUMP_HOSTNAME_NAME=DB_HOSTNAME_CENTRAL ... means that MTK_DUMP_HOSTNAME will be set to the value of DB_HOSTNAME_CENTRAL Primary Changes --------------- - Added calc_MTK_variable function which sets up one MTK_DUMP_* variable - Set all the MTK_DUMP_* variables using the above function (and replaced existing code that set them) - Changed GraphQL example to allow for the new variables Other changes ------------- - Removed san_db_tarfile line since it's not used - A few tweaks based on the output of https://www.shellcheck.net/ (which you can install locally)
For the record, this one was discussed with Sean. Our plan is that:
HTH, |
shreddedbacon
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this. I'd just like the example graphql command split to its own example file.
a new separate example file
Hi @shreddedbacon , have updated the PR as requested. Thanks! |
shreddedbacon
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To allow the passing of the MTK_DUMP_* variables into the task in one
way or another, rather than assuming that the database is going to be
the one in the Lagoon service
Also instead allow the passing of the name of a variable that contains
the MTK_DUMP_* value. For example,
... means that MTK_DUMP_HOSTNAME will be set to the value of
DB_HOSTNAME_CENTRAL
Primary Changes
existing code that set them)
Other changes
you can install locally)
closes #14