refactor: dont update dbaas crds after they are provisioned #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
dbaas-apply-once
branch
from
7e462d4 to
f988fde
Compare
shreddedbacon
force-pushed
the
dbaas-apply-once
branch
from
f988fde to
e29fd34
Compare
shreddedbacon
force-pushed
the
dbaas-apply-once
branch
from
e29fd34 to
b655c49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since modifying these after their creation can lead to deprovisioning issues, don't update them (except for labels).
Migrations for these resources are currently done manually anyway, this just further protects deprovisioning success.
Once the new dbaas controller is released properly with integration in Lagoon, this entire process will be different.