Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup old certificates for ingress that have tls-acme false #231

Merged
merged 2 commits into from
Oct 9, 2023
Merged

refactor: cleanup old certificates for ingress that have tls-acme false #231

merged 2 commits into from
Oct 9, 2023

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Sep 14, 2023 •
edited
Loading

Clean up any certificate resources when an ingress has tls-acme: false set

closes #227

@shreddedbacon shreddedbacon marked this pull request as ready for review September 14, 2023 23:55
@tobybellwood tobybellwood added this to the v2.16 tie-in release milestone Sep 18, 2023
@tobybellwood tobybellwood merged commit 963e16d into main Oct 9, 2023
2 checks passed
@tobybellwood tobybellwood deleted the remove-tls-resources-if-false branch October 9, 2023 02:35
@tobybellwood tobybellwood mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.16 tie-in release
Development

Successfully merging this pull request may close these issues.

Settings tls-acme to false should remove existing Certificate objects that are not Ready
2 participants
@shreddedbacon @tobybellwood