Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add primaryingress label to primary ingress #153

Merged
merged 2 commits into from
Jan 3, 2023
Merged

chore: add primaryingress label to primary ingress #153

merged 2 commits into from
Jan 3, 2023

Conversation

shreddedbacon
Copy link
Member

closes #149

tobybellwood
tobybellwood approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense. It'll tie in nicely with an improvement to the route handling

@shreddedbacon shreddedbacon merged commit e1c7f8f into main Jan 3, 2023
@shreddedbacon shreddedbacon deleted the primary-ingress-label branch January 3, 2023 21:44
@shreddedbacon shreddedbacon mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

@smlx smlx smlx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Primary ingress domains shoud be labled
3 participants
@shreddedbacon @smlx @tobybellwood