#131 #132 #88 Combination PR #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional information for container-registry credential sourcing
…assword overrride
…iner-registry-password-override
…log-verbosity-container-registry-password-override
shreddedbacon
changed the title
shreddedbacon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this combines the code of PR #131 #132 and #88 in a single PR as it's used by a customer of us
EDIT: Note from @shreddedbacon, this PR is not for merging. #132 will be the one that ends up being merged while #88 gets some more eyes over it to see if we want to merge this properly or not. The latest
remote-controllerno longer will encounter issues with the size of build logs, but I think the verbosity PR should still be merged as it cuts out a lot of noise.