Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

divand: --user 999 not needed anymore #908

Merged
merged 2 commits into from
Oct 2, 2023
Merged

divand: --user 999 not needed anymore #908

merged 2 commits into from
Oct 2, 2023

Conversation

bgruening
Copy link
Member

No description provided.

@bgruening
Copy link
Member Author

@kysrpex do you know why this is failing?

@kysrpex
Copy link
Contributor

kysrpex commented Sep 19, 2023

@kysrpex do you know why this is failing?

What is failing? ITs? Divand? TPV dry-run?

@bgruening
Copy link
Member Author

This PR here :)

@bgruening
Copy link
Member Author

@kysrpex any idea why this PR is failing?

@kysrpex
Copy link
Contributor

kysrpex commented Oct 2, 2023

Can you give a bit of context? What does not work? Writing the outputs? Running the IT? Reading the datasets?

@bgruening
Copy link
Member Author

This Pull request here, is failing in the dry-run ... not sure what else I can say :)

@kysrpex
Copy link
Contributor

kysrpex commented Oct 2, 2023

In this message

What is failing? ITs? Divand? TPV dry-run?

I have asked if the TPV dry-run is failing.

not sure what else I can say :)

Next time just say: "TPV dry-run is failing" :)


This rule uses helpers.tool_version_gte but tool.version is None for the mock tool TPV uses for the dry-run.

Solution: move the rule under the alphafold key in tools.yml (then it fails only for alphafold), do not use Python's all or fix the issue in TPV.

@kysrpex kysrpex changed the title not needed anymore divand: --user 999 not needed anymore Oct 2, 2023
@kysrpex
Copy link
Contributor

kysrpex commented Oct 2, 2023

#919 should fix it, we can merge it to master, merge master into this branch and then merge this branch.

@kysrpex
Copy link
Contributor

kysrpex commented Oct 2, 2023

New error:

galaxy.jobs.mapper.JobMappingException: Interactive tools require registration. Please log-in or register on https://usegalaxy.eu/login

Do we fix it or do we merge? Really, the TPV dry-run logic needs some attention (e.g. it should not fail when things are working as expected, just like in this case).

@bgruening
Copy link
Member Author

Feel free to merge!

@kysrpex kysrpex self-assigned this Oct 2, 2023
@kysrpex kysrpex merged commit 5253b2d into master Oct 2, 2023
@kysrpex kysrpex deleted the bgruening-patch-5 branch October 2, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants