Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image thumbnail upload logic for size validation #163

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

arash77
Copy link
Collaborator

@arash77 arash77 commented Jan 8, 2025

Implement a check for image content size before uploading thumbnails to ensure only appropriately sized images (976.56) are processed in BlueSky.

@arash77 arash77 mentioned this pull request Jan 8, 2025
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a ticket so we do not loose track about this.
1MB is really large, maybe we should run an optimization step on the images.

@arash77
Copy link
Collaborator Author

arash77 commented Jan 9, 2025

Now this will fix the problem with #164

@bgruening
Copy link
Member

@arash77
Copy link
Collaborator Author

arash77 commented Jan 9, 2025

Maybe relevant: https://github.com/galaxyproject/galaxy-hub/blob/master/.github/workflows/optimize-images.yml

It is more complex to use a GitHub action step because we need first to extract the thumbnail image from the URL and then compress it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants