Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeouts and improve handling of high-latency connections #93

Merged
merged 1 commit into from
May 4, 2024

Conversation

nuwang
Copy link
Contributor

@nuwang nuwang commented May 3, 2024

This is a follow up on an issue reported last year: #75

@mthang and I investigated further and found that the instability was due to the high-latency and load between the ftp server and Galaxy Australia. It required two fixes.

  1. Increase client timeouts to deal with the higher latency
  2. Enhance the existing workaround for dealing with reused ssl sockets based on: https://stackoverflow.com/a/53456626/10971151 and https://stackoverflow.com/a/70830916/10971151

# fix reuse of ssl socket:
# https://stackoverflow.com/a/53456626/10971151 and
# https://stackoverflow.com/a/70830916/10971151
def custom_unwrap():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting!

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nuwang!

@bedroesb ok for you?

Copy link
Collaborator

@bedroesb bedroesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting indeed, thanks a lot for looking into this!

@bgruening bgruening merged commit 97e18a2 into usegalaxy-eu:master May 4, 2024
1 check passed
@nuwang nuwang deleted the patch-1 branch May 7, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants