-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Balance integration fix #1982
base: master
Are you sure you want to change the base?
Balance integration fix #1982
Conversation
Now is the same as in the e2e tests!
@@ -306,7 +306,8 @@ where | |||
instance.engine.set_callee(encoded_alice.clone()); | |||
|
|||
// set up the funds for the default accounts | |||
let substantial = 1_000_000; | |||
// the 1_000_000_000 is the same value as in the e2e tests | |||
let substantial = 1_000_000_000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original 1_000_000
value was somewhat arbitrary anyway, so makes sense to change it to be the same as the substrate-contracts-node
used for testsin.
Is it only the Alice account that is endowed with this amount? I see bob and charlie are still set to 1_000
below - does that match up with the endowed amounts for the e2e tests too? Seems kind of low.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, i will check the behaviour and make it equal for all name accounts (at least). The accounts created with ::From([1;32])
should have a balance of 0 or the existential minimum?
This is the same value as substrate-contracts-node/node/src/chain_spec.rs `test_genesis` function
I changed the value to be the same as the testnet genesis. This is the same value that this test gives in an e2e test.
In this case, |
@faculerena Could you merge |
Summary
cargo-contract
orpallet-contracts
?Updated the default balance in integration tests.
Description
We updated the default balance in integration tests to be the same as in e2e-tests. This is not definitive, as we want opinions if this should be like this.
Checklist before requesting a review
CHANGELOG.md