Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address link-check failure for supercolony #272

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

0xf333
Copy link
Contributor

@0xf333 0xf333 commented Aug 29, 2023

Outdated links are causing markdown-link-check check to fail during pull request checks.

Description

Old link: https://supercolony.net/ (404 webpage)
Replaced by: https://brushfam.io/

Impact

This PR fixes failure associated with Supercolony link.

Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Supercolony has become Brushfam now, https://brushfam.io, https://github.com/Brushfam

@0xf333
Copy link
Contributor Author

0xf333 commented Aug 31, 2023

I believe Supercolony has become Brushfam now, https://brushfam.io, https://github.com/Brushfam

Hi @ascjones , thanks for the feedback, it's done.

@ascjones
Copy link
Collaborator

ascjones commented Sep 6, 2023

I believe Supercolony has become Brushfam now, https://brushfam.io, https://github.com/Brushfam

Hi @ascjones , thanks for the feedback, it's done.

I spoke to the Brushfam guys, they said that these two links should remain supercolony, since that organisation does still exist and did the original work referenced. Sorry about that!

@0xf333
Copy link
Contributor Author

0xf333 commented Sep 7, 2023

I believe Supercolony has become Brushfam now, https://brushfam.io, https://github.com/Brushfam

Hi @ascjones , thanks for the feedback, it's done.

I spoke to the Brushfam guys, they said that these two links should remain supercolony, since that organisation does still exist and did the original work referenced. Sorry about that!

Hi @ascjones, thanks for the feedback.
Since https://supercolony.net still giving a 404 HTTP response, perhaps we should use https://github.com/Supercolony-net instead?
Let me know what you think.

@ascjones
Copy link
Collaborator

ascjones commented Sep 8, 2023

I believe Supercolony has become Brushfam now, https://brushfam.io, https://github.com/Brushfam

Hi @ascjones , thanks for the feedback, it's done.

I spoke to the Brushfam guys, they said that these two links should remain supercolony, since that organisation does still exist and did the original work referenced. Sorry about that!

Hi @ascjones, thanks for the feedback. Since https://supercolony.net still giving a 404 HTTP response, perhaps we should use https://github.com/Supercolony-net instead? Let me know what you think.

Yes, just link the github 👍

Outdated links are causing `markdown-link-check`
check to fail during pull request checks.

Description
===========
`Old link`: https://supercolony.net/ (404 webpage)
`Replaced by`: https://github.com/Supercolony-net

Impact
======
This PR fixes failure associated with Supercolony link.
@0xf333
Copy link
Contributor Author

0xf333 commented Sep 8, 2023

Yes, just link the github 👍

Thanks for the feedback, it's done.

Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Chris!

@cmichi cmichi merged commit 45670bd into use-ink:master Jan 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants