Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet list to the ink docs #263

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Add wallet list to the ink docs #263

merged 6 commits into from
Oct 5, 2023

Conversation

saltict
Copy link
Contributor

@saltict saltict commented Aug 25, 2023

Description

SubWallet, Polkadot{.js}, and Talisman are the walllets that support interacting with Ink smart contracts.
SubWallet is the first wallet to support PSP22 and PSP34 tokens written with Ink smart contracts. SubWallet's compatibility enhances the accessibility of these tokens, allowing users to seamlessly manage and interact with them. This pull request aims to enhance the Ink documentation by adding SubWallet as a supported wallet for interacting with Ink smart contracts.

Details

  1. Modified intro.mdx: Added SubWallet to the list of supported wallets in the Ink documentation and linked to https://subwallet.app.
  2. Added /static/img/wallets/subwallet.svg, /static/img/wallets/polkadot-js.svg, /static/img/wallets/talisman.svg.
  3. Modified custom.css for the wallet section.

Screenshot

image
image

These screenshots provides a visual representation of the changes that have been made.

Testing

I deployed the changes to the demo for preview purposes.

Additional Notes

SubWallet has already added support for Ink:

Contributors

Your consideration of this pull request is highly appreciated. Thank you!

Sincerely,
Peter Mai

@SkymanOne
Copy link
Contributor

Would be nice if you added a quick article in Third Party Tools & Libraries about the supported PSP standards by Subwallet and how they are displayed

@@ -198,6 +198,16 @@ hide_table_of_contents: false
<div className="col">&nbsp;</div>
</div>

## What wallet can I use?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## What wallet can I use?
## What wallets can I use?

I hope there will be more :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus one for this suggestion.

Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

So strictly speaking you can also use e.g. polkadot-js or Talisman as wallets to interact with contracts. So the title "Which wallet can I use?" can appear as frightening if we only refer SubWallet here.

It's clear to me that you mean it in the context of PSP standards supported by wallets. I think it would be best to under the title "Which wallet can I use?" have a bunch of logos and then a table that compares the wallets against each other.

So something like

SubWallet polkadot-js Talisman
Interacting with Contracts
NFT's (PSP-34)

Please also move the "Which wallets can I use?" section on the intro page below the examples.

PS: Kudos for putting the graphic together like the others! We did it this way so that it also works when the light theme is switched on.

@saltict saltict changed the title Add SubWallet to the ink support wallet list Add wallet list to the ink docs Sep 9, 2023
@saltict
Copy link
Contributor Author

saltict commented Sep 9, 2023

Hi @SkymanOne and @cmichi, thank you for your suggestions.

I have updated the PR. Please help review and approve it if everything is okay

Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for this contribution!

I'm sorry for the delay in response, there were vacations and we're in the process of catching up.

@cmichi
Copy link
Collaborator

cmichi commented Oct 5, 2023

@saltict Can I ask you to merge master? There are some conflicts, they shouldn't be hard to resolve.

# Conflicts:
#	sidebars.js
@saltict saltict reopened this Oct 5, 2023
@saltict
Copy link
Contributor Author

saltict commented Oct 5, 2023

@saltict Can I ask you to merge master? There are some conflicts, they shouldn't be hard to resolve.

I resolved the problems by backing up the old master branch, sync-fork, and merging it into new master branch.

@cmichi cmichi merged commit 9ee0b70 into use-ink:master Oct 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants