-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wallet list to the ink docs #263
Conversation
Would be nice if you added a quick article in |
docs/intro/intro.mdx
Outdated
@@ -198,6 +198,16 @@ hide_table_of_contents: false | |||
<div className="col"> </div> | |||
</div> | |||
|
|||
## What wallet can I use? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## What wallet can I use? | |
## What wallets can I use? |
I hope there will be more :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus one for this suggestion.
… the supported PSP standards by Subwallet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
So strictly speaking you can also use e.g. polkadot-js
or Talisman as wallets to interact with contracts. So the title "Which wallet can I use?" can appear as frightening if we only refer SubWallet here.
It's clear to me that you mean it in the context of PSP standards supported by wallets. I think it would be best to under the title "Which wallet can I use?" have a bunch of logos and then a table that compares the wallets against each other.
So something like
SubWallet | polkadot-js |
Talisman | |
---|---|---|---|
Interacting with Contracts | ✅ | ✅ | ✅ |
NFT's (PSP-34) | ✅ | ﹣ | ﹣ |
Please also move the "Which wallets can I use?" section on the intro page below the examples.
PS: Kudos for putting the graphic together like the others! We did it this way so that it also works when the light theme is switched on.
Hi @SkymanOne and @cmichi, thank you for your suggestions. I have updated the PR. Please help review and approve it if everything is okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot for this contribution!
I'm sorry for the delay in response, there were vacations and we're in the process of catching up.
@saltict Can I ask you to merge |
# Conflicts: # sidebars.js
I resolved the problems by backing up the old master branch, sync-fork, and merging it into new master branch. |
Description
SubWallet, Polkadot{.js}, and Talisman are the walllets that support interacting with Ink smart contracts.
SubWallet is the first wallet to support PSP22 and PSP34 tokens written with Ink smart contracts. SubWallet's compatibility enhances the accessibility of these tokens, allowing users to seamlessly manage and interact with them. This pull request aims to enhance the Ink documentation by adding SubWallet as a supported wallet for interacting with Ink smart contracts.
Details
intro.mdx
: Added SubWallet to the list of supported wallets in the Ink documentation and linked tohttps://subwallet.app
./static/img/wallets/subwallet.svg
,/static/img/wallets/polkadot-js.svg
,/static/img/wallets/talisman.svg
.custom.css
for the wallet section.Screenshot
These screenshots provides a visual representation of the changes that have been made.
Testing
I deployed the changes to the demo for preview purposes.
Additional Notes
SubWallet has already added support for Ink:
Contributors
Your consideration of this pull request is highly appreciated. Thank you!
Sincerely,
Peter Mai