Skip to content

Commit

Permalink
clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
masimons committed Aug 6, 2024
1 parent ff7d467 commit 99a36c9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions packages/server/src/lib/grants-ingest.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ function mapSourceDataToGrant(source) {
// depending on how we model the estimated open date, we may need to do the
// date comparison with the new field for estimated date
grant.opportunity_status = 'forecasted'

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (91% of all statements in
the enclosing function
have an explicit semicolon).
// This may be extraneous code
// because in the knex query, we are deriving the status based on
// archive_date and close_date
// Note: in the knex query, we are deriving the status based on
// archive_date and close_date. Probably we just want to pass
// the opportunity_status to the frontend, and not re-derive it here?
} else {
grant.opportunity_status = 'posted';
}
Expand Down
1 change: 0 additions & 1 deletion packages/server/src/routes/grants.js
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ router.get('/exportCSV', requireUser, async (req, res) => {
// Generate CSV
const formattedData = data.map((grant) => ({
...grant,
//opportunity_status: titleize(grant.opportunity_status),
interested_agencies: grant.interested_agencies
.map((v) => v.agency_abbreviation)
.join(', '),
Expand Down

0 comments on commit 99a36c9

Please sign in to comment.