fix: remove ability to delete from s3 due to permissions issue (#349)

* fix: remove ability to delete from s3 due to permissions issue * fix: use structured logging
usdigitalresponse · Jun 28, 2024 · 5bea8be · 5bea8be
1 parent 9f1ba1f
commit 5bea8be
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/api/src/services/uploads/uploads.test.ts b/api/src/services/uploads/uploads.test.ts
@@ -137,7 +137,7 @@ describe('uploads', () => {
     await deleteUpload({
       id: scenario.upload.one.id,
     })
-    expect(deleteUploadFile).toHaveBeenCalled()
+    expect(deleteUploadFile).not.toHaveBeenCalled()
   })
 
   scenario(

diff --git a/api/src/services/uploads/uploads.ts b/api/src/services/uploads/uploads.ts
@@ -6,7 +6,7 @@ import type {
 } from 'types/graphql'
 
 import { hasRole } from 'src/lib/auth'
-import { s3PutSignedUrl, deleteUploadFile } from 'src/lib/aws'
+import { s3PutSignedUrl } from 'src/lib/aws'
 import aws from 'src/lib/aws'
 import { ROLES } from 'src/lib/constants'
 import { db } from 'src/lib/db'
@@ -95,7 +95,9 @@ export const deleteUpload: MutationResolvers['deleteUpload'] = ({ id }) => {
   if (!upload) {
     throw new ValidationError(`Upload with id ${id} not found`)
   }
-  deleteUploadFile(upload)
+  // TODO: fix aws permissions issue on ECS instance. For now, we'll just log the delete
+  // deleteUploadFile(upload)
+  logger.info({ upload_id: id }, 'deleted database record for upload')
 
   // 2. delete the upload
   return db.upload.delete({