Skip to content

Commit

Permalink
fix: add report.zip in the correct s3 path (#457)
Browse files Browse the repository at this point in the history
  • Loading branch information
as1729 authored Oct 1, 2024
1 parent dec0992 commit 53f3ba4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion python/src/functions/create_archive.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def create_archive(
zipf.close()
file.flush()
logger.info(f"Created archive file: {file.name}")
upload_key = "report.zip"
upload_key = f"{target_key}report.zip"
# upload the zip file to the target key

s3_client.upload_file(file.name, S3_BUCKET, upload_key)
Expand Down
2 changes: 1 addition & 1 deletion python/tests/src/lib/test_create_archive.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def test_create_archive_creates_zip():

# Assert that the file was attempted to be created
s3_client.upload_file.assert_called_with(
ANY, "test_bucket", "report.zip"
ANY, "test_bucket", "treasuryreports/1234/5678/report.zip"
)


Expand Down

0 comments on commit 53f3ba4

Please sign in to comment.