Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(solid): Correctly track query data reads with suspense #3672

Merged
merged 2 commits into from
Sep 14, 2024
Merged

fix(solid): Correctly track query data reads with suspense #3672

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90def5a
fix(solid): Correctly track query data reads with suspense
XiNiHa Sep 13, 2024
f24ac1d
Update .changeset/healthy-years-ring.md
JoviDeCroock Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-years-ring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@urql/solid': patch
---

fix(solid): Correctly track query data reads with suspense
JoviDeCroock marked this conversation as resolved.
Show resolved Hide resolved
6 changes: 1 addition & 5 deletions packages/solid-urql/src/createQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,11 +321,7 @@ export const createQuery = <
): any {
if (isSuspense() && prop === 'data') {
const resource = dataResource();
if (resource !== undefined) {
return resource.data;
}

return undefined;
if (resource === undefined) return undefined;
}

return Reflect.get(target, prop);
Expand Down