Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fixed relative path to assets #22

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix(app): fixed relative path to assets #22

merged 1 commit into from
Aug 10, 2023

Conversation

cTux
Copy link
Collaborator

@cTux cTux commented Aug 10, 2023

Description

Fixed bug (using vitejs baseUrl + routing), index.html now contains correct absolute path to assets.

@cTux cTux self-assigned this Aug 10, 2023
@github-actions
Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Fixed relative path to assets
  • 📌 Type of PR: Bug fix
  • Focused PR: True
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • General suggestions: The PR looks good overall. It fixes the bug related to the relative path to assets and updates the base configuration in vite.config.ts to use an absolute path. However, it would be beneficial to add relevant tests to ensure the bug is properly fixed and to prevent regressions in the future.

  • 🤖 Code feedback:

    • relevant file: vite.config.ts
      suggestion: Consider adding a comment explaining the reason for using an absolute path as the base. This will help future developers understand the intention behind the change. [medium]
      relevant line: base: '/',

    • relevant file: vite.config.ts
      suggestion: Remove the duplicate port declaration in vite.config.ts. It is already declared above. [medium]
      relevant line: export const port = 5173;

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve: Suggest improvements to the code in the PR.
/ask <QUESTION>: Pose a question about the PR.

To edit any configuration parameter from 'configuration.toml', add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

Copy link
Collaborator

@YuriyPanasiuk YuriyPanasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cTux cTux merged commit b5dddb0 into develop Aug 10, 2023
4 checks passed
@cTux cTux deleted the fix/base-url branch August 10, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants