FEC-10 feat: add commit lint on create PR and pre commit hooks #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quatrolavita
changed the title
quatrolavita
force-pushed
the
feat/add_commit_lint
branch
from
e7995ea
to
c422699
Compare
quatrolavita
requested review from
cTux,
MaxKalashnyk,
yarikhot and
YuriyPanasiuk
quatrolavita
changed the title
quatrolavita
changed the title
cTux
approved these changes
Aug 1, 2023
| @@ -0,0 +1,3 @@ | |||
| module.exports = { | |||
| extends: ['@commitlint/config-conventional'], | |||
There was a problem hiding this comment.
Both .commitlintrc.json and commitlint.config.ts are required, right?
There was a problem hiding this comment.
yeah, they are must-have, in future we can edit commit lint rules, if needed
yarikhot
approved these changes
Aug 2, 2023
quatrolavita
force-pushed
the
feat/add_commit_lint
branch
from
868a04e
to
b8ddac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://uptech.atlassian.net/browse/FEC-10